Repository navigation
Fix live selected-RCB DataSet export - #33
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
July 19, 2026 23:05
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some IEDs report a populated DataSet during the explicit RCB availability check, while the earlier broad discovery model contains only
MemberCountand an empty member-reference list. ARSAS therefore showed1 FCDAbut live selected-RCB export failed withreferences an empty DataSet.Fix
GetDataSetDirectorymembers and deletable flag inMmsRcbAvailabilitySnapshot;LiveRcbDataSetEvidenceMergerto merge the selected RCB's verified DataSet directory into a cloned live model;Regression coverage
The test reproduces the field case directly: discovery says
MemberCount=1butMembers=[]; availability returns one exact member. The merged model then passes selected-RCB filtering while the original model remains unchanged.Validation
Public-source checks, Release build, and all automated tests passed. Temporary implementation workflows and patch files were removed before review.