Skip to content

Fix live selected-RCB DataSet export - #33

Merged
masarray merged 14 commits into
mainfrom
fix/live-rcb-dataset-export
Jul 19, 2026
Merged

masarray merged 14 commits into
mainfrom
fix/live-rcb-dataset-export

Conversation

@masarray

@masarray masarray commented Jul 19, 2026 •

Copy link
Copy Markdown
Owner

Problem

Some IEDs report a populated DataSet during the explicit RCB availability check, while the earlier broad discovery model contains only MemberCount and an empty member-reference list. ARSAS therefore showed 1 FCDA but live selected-RCB export failed with references an empty DataSet.

Fix

  • preserve the exact GetDataSetDirectory members and deletable flag in MmsRcbAvailabilitySnapshot;
  • add LiveRcbDataSetEvidenceMerger to merge the selected RCB's verified DataSet directory into a cloned live model;
  • never mutate the original discovery model;
  • reject export with a clear instruction when Check Availability evidence is absent, unreadable, or contains no usable references;
  • retain the existing selected-RCB filter and SCL exporter after the model is enriched.

Regression coverage

The test reproduces the field case directly: discovery says MemberCount=1 but Members=[]; availability returns one exact member. The merged model then passes selected-RCB filtering while the original model remains unchanged.

Validation

Public-source checks, Release build, and all automated tests passed. Temporary implementation workflows and patch files were removed before review.

@masarray
masarray marked this pull request as ready for review July 19, 2026 23:05
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit cfc054b into main Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant