Repository navigation
P0: real SV phasor angles, nominal 4I+4V presentation and honest sync diagnostics #215
ci.yml
on: pull_request
Build, test, and repository health
1m 20s
Annotations
10 warnings
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Analysis/RawProcessBusAnalyzer.cs#L311
The behavior of 'ushort.ToString()' could vary based on the current user's locale settings. Replace this call in 'RawProcessBusAnalyzer.ResolveSvMappingProfile(ProcessBusFrame, SampledValueAsdu)' with a call to 'ushort.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Runtime/SvRuntimeSnapshot.cs#L169
Use 'ArgumentOutOfRangeException.ThrowIfNegative' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1512)
|
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L34
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L31
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L28
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build, test, and repository health:
src/ProcessBus.Iec61850.Raw/Analysis/RollingJitterWindow.cs#L23
Use 'ArgumentOutOfRangeException.ThrowIfNegativeOrZero' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1512)
|
|
Build, test, and repository health:
src/ProcessBus.Core/Services/PcapAdapterCatalog.cs#L128
Specify marshaling for P/Invoke string arguments (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2101)
|
|
Build, test, and repository health:
src/ProcessBus.Core/Services/PcapAdapterCatalog.cs#L58
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'PcapAdapterCatalog.GetAdaptersCore()' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build, test, and repository health:
src/ProcessBus.Core/Models/PtpEventItem.cs#L6
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'PtpEventItem.TimeText.get' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build, test, and repository health:
src/ProcessBus.Core/Services/Scl/SclSemanticParser.cs#L9
Member 'Load' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
test-evidence-39033981689
|
170 KB |
sha256:491ed3363da5a07678a5ebb69fd8c8af77f93245c70d4fbd7911c85de522c986
|
|