Skip to content

fix(raw-sv): recover 4I4V rate from verified smpCnt rollover without SCL - #24

Merged
masarray merged 1 commit into
mainfrom
fix/sv-optional-smp-rate-pcap-evidence-20261016
Oct 16, 2026
Merged

masarray merged 1 commit into
mainfrom
fix/sv-optional-smp-rate-pcap-evidence-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Physical repro (16 October 2026)

Operator-captured classic PCAP from ESP32-P4 -> ASIX NIC: 40,171 canonical ARSTACK_SV01 SV frames in 10.0427s, 4,000.023 fps, 40,170/40,170 contiguous smpCnt, 64-byte samples; a separate intentional AR_DIAG_SV1 mirror is present. Primary stream omits optional ASDU smpRate/smpMod while DigSub's ResolveWaveformSampleRate() returned 0 and showed rate N/A. The customer's PCAP itself is NOT committed.

Change

  • A stream with no explicit smpRate may derive only 4000/4800 from an observed rollover 3999/4799 -> 0 and independent rolling host-arrival-rate screening within ±10%, with provenance label (estimated, not on wire).
  • Reset derived evidence on sequence errors; never infer based on svID alone or from missing optional fields without proof. Existing raw sample/channel fallback remains available before rate proof and without SCL.
  • Distinguish 4000/50 Hz and 4800/60 Hz; do not label all rates >=4000 as 50 Hz.
  • Add synthetic 4I4V high-rate rollover regression and negative unverified-rate regression.

Boundaries

Receive-only; does not invent calibrated PTP timing or packet timestamps, modify publisher, claim physical certification, or publish raw operator captures. Draft pending build/test and physical installer retest.

@masarray
masarray marked this pull request as ready for review October 16, 2026 00:06
@masarray
masarray merged commit d671f3b into main Oct 16, 2026
13 checks passed
@masarray
masarray deleted the fix/sv-optional-smp-rate-pcap-evidence-20261016 branch October 16, 2026 00:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T00:07:26.082107Z 65d3e21 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant