Repository navigation
fix(raw-sv): recover 4I4V rate from verified smpCnt rollover without SCL - #24
Merged
Merged
Conversation
… rate without SCL
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical repro (16 October 2026)
Operator-captured classic PCAP from ESP32-P4 -> ASIX NIC: 40,171 canonical
ARSTACK_SV01SV frames in 10.0427s, 4,000.023 fps, 40,170/40,170 contiguoussmpCnt, 64-byte samples; a separate intentionalAR_DIAG_SV1mirror is present. Primary stream omits optional ASDUsmpRate/smpModwhile DigSub'sResolveWaveformSampleRate()returned 0 and showed rate N/A. The customer's PCAP itself is NOT committed.Change
smpRatemay derive only 4000/4800 from an observed rollover3999/4799 -> 0and independent rolling host-arrival-rate screening within ±10%, with provenance label (estimated, not on wire).svIDalone or from missing optional fields without proof. Existing raw sample/channel fallback remains available before rate proof and without SCL.Boundaries
Receive-only; does not invent calibrated PTP timing or packet timestamps, modify publisher, claim physical certification, or publish raw operator captures. Draft pending build/test and physical installer retest.