Repository navigation
Final physical bench candidate: bundled offline PCAP/SCL CLI, measurement script and verified Windows ZIP - #32
Conversation
… bench checklist with Windows candidate
…s and 60-minute physical evidence contract
…physical bench documentation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f14f93fb28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Copy-Item (Join-Path $repoRoot "docs/M4_ARSTACK_INTEROP_ACCEPTANCE.md") (Join-Path $interopStageDir "M4_ARSTACK_INTEROP_ACCEPTANCE.md") -Force | ||
| Copy-Item (Join-Path $repoRoot "scripts/measure-m4-bench.ps1") (Join-Path $interopStageDir "measure-m4-bench.ps1") -Force |
There was a problem hiding this comment.
When an operator follows the copied Bench/M4_ARSTACK_INTEROP_ACCEPTANCE.md, its performance command targets .\scripts\measure-m4-bench.ps1, but the package stages the script under Bench; even after correcting that path manually, the command omits -ProcessName, so the script defaults to ProcessBus.App.Wpf while the packaged executable runs as ProcessBusInsight. The documented 60-minute run therefore either fails immediately or records only missing-process rows, so update the packaged runbook and/or the script default.
Useful? React with 👍 / 👎.
| $interopProject = Join-Path $repoRoot "tools/ProcessBus.InteropCli/ProcessBus.InteropCli.csproj" | ||
| $interopPublishDir = Join-Path $repoRoot "$OutputRoot/publish/$portableName/interop-cli" |
There was a problem hiding this comment.
Now that the release artifact is built from tools/ProcessBus.InteropCli, a PR changing only that project will not trigger .github/workflows/candidate-package.yml: its pull_request.paths list includes src/** and tests/** but not tools/**. Such changes receive the ordinary compile/test job but skip the self-contained publish and packaged --help smoke test added here, so a candidate can be merged without exercising the new artifact path; add the bundled tool path (and the other newly copied bench inputs) to that workflow's triggers.
Useful? React with 👍 / 👎.
1 participant
Why
The previous Windows x64 candidate only included the desktop EXE. Users conducting independent physical SV/PTP tests lacked a packaged PCAP+SCL inspection CLI, bench runbook, and 60-minute CPU/memory sampler despite those tools existing in source. This PR closes that release usability gap without creating any new IEC 61850 protocol model or loosening evidence rules.
Changed
ProcessBus.InteropCli.exeas an additional self-contained win-x64 tool inBench/of the portable ZIP; the root still contains exactly one GUI EXE.Bench/START_HERE.md, full M4 acceptance runbook, and read-onlymeasure-m4-bench.ps1in the artifact.InteropCli.exe --helpon Windows. Candidate-build workflow must pass Publish -> Verify -> Upload.Gate
CI Windows, xUnit, Runtime Stability, CodeQL, Dependency Review and successful verified downloadable win-x64 candidate artifact on the same head SHA. Merge only after gates pass; then link the candidate artifact directly.