Repository navigation
UX: quiet analyzer hierarchy, aligned phase metering and static waveform canvas - #34
Conversation
…static oscilloscope surface
…tic source navigation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08809af521
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Visibility="Collapsed" | ||
| ToolTip="{Binding IssueSummaryText}"/> |
There was a problem hiding this comment.
When an SV or PTP target has a warning, this removes IssueSummaryText from the layout and attaches its tooltip to the same collapsed element. A collapsed WPF element cannot be hovered or hit-tested, so the tooltip is unreachable; the remaining visible selected-target issue binding is in the GOOSE-specific cards, leaving SV/PTP operators without the warning explanation. Keep the summary visible or attach the tooltip to the containing target row.
Useful? React with 👍 / 👎.
| <Border Style="{StaticResource MetricChipBorderStyle}" | ||
| Visibility="Collapsed" | ||
| ToolTip="{Binding WaveformShapeStatusText}"> |
There was a problem hiding this comment.
When waveform analysis reports distortion, an unavailable source, or another shape warning, this border is collapsed and therefore cannot receive hover input, making the stated tooltip behavior impossible. This is the only WaveformShapeStatusText binding in the UI, so the diagnostic becomes completely inaccessible; move the tooltip to the visible scope/header or provide another visible affordance.
Useful? React with 👍 / 👎.
| <ColumnDefinition Width="30"/> | ||
| <ColumnDefinition Width="*"/> | ||
| <ColumnDefinition Width="67"/> | ||
| <ColumnDefinition Width="57"/> |
There was a problem hiding this comment.
For any live numeric phase, ChannelValueModel.AngleDisplayText emits values such as -120.00 deg. The new 57-DIP column leaves only 50 DIPs after the 7-DIP left margin, while the simultaneously enlarged 11-DIP Consolas text needs more space even for common values, so TextTrimming="CharacterEllipsis" truncates the angles across all six rows. Increase or auto-size the angle column, or shorten the formatted value.
Useful? React with 👍 / 👎.
1 participant
Screenshot-driven operator UX cleanup. Reduces competing panel titles/subtitles and waveform decorative animation, aligns the six-phase RMS/angle ledger with consistent typographic hierarchy, and clarifies Timing/PTP without claiming lock or hiding protocol evidence. Read-only capture and IEC 61850 parsing unchanged. Windows CI and candidate packaging must pass; field screenshot validation still required.