Skip to content

Final operator UX: coherent PTP counters, readable phase meter and compact diagnostics - #35

Merged
masarray merged 7 commits into
mainfrom
fix/final-premium-ux-20261017
Oct 17, 2026
Merged

masarray merged 7 commits into
mainfrom
fix/final-premium-ux-20261017

Conversation

@masarray

Copy link
Copy Markdown
Owner

Implemented

  • Fix live PTP two-step headline inconsistency by notifying the replaced Diagnostics snapshot (normal Diagnostics and Timing workspaces).
  • Replace cramped phase ledger with aligned phase / RMS / explicit unit / angle columns and reusable WPF readout styles. Give measurement panel enough vertical space at reduced resolutions without altering the actual sample waveform or phasor calculations.
  • Fail closed for unprovided engineering unit or NaN/Infinity; retain legitimate counts and operator-supplied scaling only.
  • Virtualized, bounded capture-wide findings list: concise summary, explicit source when evidenced, original full message available on selection. Correct misleading target-scoped heading.
  • Add xUnit regression for meter semantics and evidence preservation; document acceptance and bench blockers.

Gates (do not merge before success)

  • CI Windows Release build + tests
  • Runtime stability
  • CodeQL
  • Dependency review
  • Verified win-x64 portable artifact
  • Windows pixel/keyboard DPI QA (manual; remains unverified without GUI runner)

Physical SV/PTP/IED bench acceptance remains separately open (#30). This PR does not claim certified clock LOCK, publisher fault from USB/Npcap arrival variation, or calibrated measurements without authority.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T11:34:54.164682Z 1e029e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit a4733b0 into main Oct 17, 2026
7 checks passed
@masarray
masarray deleted the fix/final-premium-ux-20261017 branch October 17, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant