Skip to content

Restore engineering-first SV diagnostics: jitter, smpCnt jumps, missing samples and quality - #36

Merged
masarray merged 7 commits into
mainfrom
fix/restore-sv-diagnostics-telemetry-20261017
Oct 17, 2026
Merged

masarray merged 7 commits into
mainfrom
fix/restore-sv-diagnostics-telemetry-20261017

Conversation

@masarray

Copy link
Copy Markdown
Owner

Root cause

The previous operator-UX PR demoted jitter to a secondary line beneath frequency, while sequence-jump and missing-sample counts were in tooltips or evidence text. These are primary IEC 61850 process-bus diagnostics and should be visible without opening the forensic log.

Real changes

  • Four prominent selected-SV telemetry readings: signed host arrival jitter with mean/max absolute variation and ≥300 µs excursion counts, discontinuous smpCnt events, missing samples, and actual SV q/TEST/blocked/invalid quality + smpSynch evidence.
  • Show last smpCnt and capture-wide decode rejects without falsely making the latter a per-stream field.
  • Restore actual-vs-expected receive interval and capture NIC drop/timestamp authority in a concise line; avoid claiming actual IED hardware sync or publisher fault from Npcap/USB timing.
  • Diagnostic SV target now follows the authoritative selected Analyzer SV stream; explicit GOOSE/PTP diagnostic selections remain independent.
  • Correct rollover smpCnt=0 erroneously treated as broken.
  • Add 10 model tests covering signed jitter, 5s excursion counts, multi-ASDU unavailable timing, nonfinite numbers, sequence/missing separation, valid zero sample counter, q/sync authority.

Release gates

  • CI Windows Release build and xUnit
  • Runtime stability
  • CodeQL
  • Dependency review
  • Portable candidate verified
  • Manual Windows pixel QA (needs actual GUI runner)

Physical acceptance #30 stays open. No changes to raw wire parser, subscriber safety, or engineering scaling authority.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-17T11:54:25.601367Z 0e33fe4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit bed1fcf into main Oct 17, 2026
7 checks passed
@masarray
masarray deleted the fix/restore-sv-diagnostics-telemetry-20261017 branch October 17, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant