Skip to content

Fix idle analyzer: nominal 4I+4V preset and honest waveform LIVE state - #38

Merged
masarray merged 5 commits into
mainfrom
fix/nominal-default-awaiting-sv-20261017
Oct 17, 2026
Merged

masarray merged 5 commits into
mainfrom
fix/nominal-default-awaiting-sv-20261017

Conversation

@masarray

Copy link
Copy Markdown
Owner

Screenshot regression

When capture is running but no SV publisher has been discovered, Analyzer displays Raw counts even though 4I+4V nominal is the preferred display preset, and the scope falsely shows a green LIVE badge. Screenshot correctly shows “Listening · Waiting for SV publisher”, empty stream list, and N/A measurements.

Implemented

  • Initial scale selector now reads 4I+4V nominal while idle, with a tooltip clarifying assumption and no available measurement; selector is disabled until a stream is selected.
  • Once exact supported 4I+4V instMag/q profile is decoded, the existing model applies assumed nominal V/A scaling per stream; unknown layouts remain raw unless selected explicitly.
  • Scope LIVE badge appears only when selected SV is active and capture is running; active capture alone is not a live SV publisher.
  • Notify the computed status on selection, runtime updates, and start/stop.
  • Regression test proves preset selection does not invent RMS or phasor data without a publisher.

Acceptance

  • Windows Release build and tests
  • Runtime stability
  • CodeQL
  • Dependency review
  • win-x64 portable candidate
  • Windows GUI review with empty → live → stopped SV stream and saved raw override
  • Physical lab traffic is not available to CI.

No raw decoder or packet capture changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-17T13:22:51.137237Z c2ec820 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 4cf439e into main Oct 17, 2026
7 checks passed
@masarray
masarray deleted the fix/nominal-default-awaiting-sv-20261017 branch October 17, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant