Repository navigation
Fix live waveform flat-line startup and compact engineering UX - #40
Merged
Merged
Conversation
…e drops to prevent flat-line startup
…cope when publisher changes
…etails disclosed on demand
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause verified against live screenshot
The measured phasors/RMS were already nominal (57.73 V, 1 A), but scope axes showed 104.5 kVpk / 1.81 kApk and initially rendered flat curves. A reused WPF oscilloscope control held raw-count auto-peak history for up to six seconds (and repeated changes could extend perceived delay). This is a display-scale authority bug, not 15 s of missing SV packets or invalid injection.
Changes implemented
Required gates
Physical acceptance issue M4 physical closeout: independent canonical SV+PTP TAP capture, 60-min soak, and IED acceptance #30 remains open. PR CI cannot prove measured live startup latency; please test on the adapter and publisher directly.