Skip to content

Fix live waveform flat-line startup and compact engineering UX - #40

Merged
masarray merged 7 commits into
mainfrom
fix/waveform-fast-start-clean-ux-20261018
Oct 17, 2026
Merged

masarray merged 7 commits into
mainfrom
fix/waveform-fast-start-clean-ux-20261018

Conversation

@masarray

Copy link
Copy Markdown
Owner

Root cause verified against live screenshot

The measured phasors/RMS were already nominal (57.73 V, 1 A), but scope axes showed 104.5 kVpk / 1.81 kApk and initially rendered flat curves. A reused WPF oscilloscope control held raw-count auto-peak history for up to six seconds (and repeated changes could extend perceived delay). This is a display-scale authority bug, not 15 s of missing SV packets or invalid injection.

Changes implemented

  • Stream-aware WPF auto-range reset; unit-aware raw counts→V/A reset, instant release when peak magnitude decreases 4x+, preserve normal peak hold for small cycle fluctuations. No changes to wire samples or RMS/phasor measurement.
  • Shared pure, xUnit-covered auto-ranging reset policy; tests include the exact 104500→104.5 V and 1810→1.81 A transitions.
  • Remove meaningless "Window: 2 cycles" chip and reclaim screen height; retain 1/2/4/8 cycles in waveform Timebase where they actually belong.
  • Normalize the 10-DIP explorer heading→SV first row spacing.
  • Replace collapsed "Power & calibration" dominated by warning text with always-visible compact P/Q/S/PF estimates, explicit UNVERIFIED mark, scaling/evidence in secondary expander; preserve all data.

Required gates

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T23:19:03.886680Z 0873317 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 9096585 into main Oct 17, 2026
7 checks passed
@masarray
masarray deleted the fix/waveform-fast-start-clean-ux-20261018 branch October 17, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant