Skip to content

P0 operator UI: consistent spacing, concise SCL matrix, decluttered diagnostics and PTP - #41

Merged
masarray merged 3 commits into
mainfrom
fix/operator-visual-hierarchy-spacing-20261018
Oct 17, 2026
Merged

masarray merged 3 commits into
mainfrom
fix/operator-visual-hierarchy-spacing-20261018

Conversation

@masarray

Copy link
Copy Markdown
Owner

Screenshot-driven fixes

  • Analyzer: remove redundant "Scaling & evidence" disclosure that occupied scarce measurements space. Keep V/A scaling chooser, tooltip and compact UNVERIFIED power evidence; P/Q/S/PF remain visible.
  • Diagnostics: remove the always-empty "Selected finding · raw evidence" expander; retain full event list and per-target Advanced evidence. Normalize KPI card gaps and 12 DIP page rhythm; compact secondary capture evidence strip.
  • Timing/PTP: remove double-framed nested metric cards, give titles 12 DIP clearance and maintain same PTP traffic, GM, sample continuity and event history.
  • SCL: shorten the hero text; compact Live Binding Matrix to 48 DIP rows with one-line expected/observed names plus concise identity check; keep original per-row evidence in tooltips and full expected/observed technical expander. Bound status summary chip widths so they do not steal catalog space. The 85% match score remains a matching heuristic, not a probability.
  • No changes to packet acquisition/IEC decoding/phasor/timing calculations.

Acceptance gates

  • Windows WPF Release build + regression tests
  • Runtime stability
  • CodeQL
  • Dependency review
  • Candidate packaging verified
  • Physical Windows visual QA at 1366×768 and 125/150% DPI (external bench, not CI).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T23:53:25.598499Z 5ffd61d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ffd61d16a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +4088 to +4089
RowHeight="48"
MinRowHeight="48"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Leave enough height for the status score

With every SCL binding row fixed at 48 DIPs, the existing row padding (6 DIPs), cell padding (12 DIPs), status badge, 4-DIP margin, and 15-DIP score line exceed the available content height. Consequently, the ScoreText line is clipped or hidden in each matrix row, even though this template still intentionally renders it. Reduce the status-cell padding/content or increase the row height, and cover the compact layout with the required rendering regression check.

AGENTS.md reference: src/AGENTS.md:L73-L75

Useful? React with 👍 / 👎.

@masarray
masarray merged commit cc005f2 into main Oct 17, 2026
7 checks passed
@masarray
masarray deleted the fix/operator-visual-hierarchy-spacing-20261018 branch October 17, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant