Skip to content

P1 UI polish: clear engineering estimates, header breathing room, and actionable empty states - #42

Merged
masarray merged 5 commits into
mainfrom
fix/p1-operator-clarity-header-goose-20261018
Oct 18, 2026
Merged

masarray merged 5 commits into
mainfrom
fix/p1-operator-clarity-header-goose-20261018

Conversation

@masarray

Copy link
Copy Markdown
Owner

User screenshot findings / changes

  • Header: remove redundant Workspace wording, left-align workspace pills and enforce 20-DIP separation from the network-adapter dropdown.
  • Measurements: replace misleading UNVERIFIED badge with quiet Nominal scale labeling. Preserve the existing scaling tooltip, engineering scale control and capture footer caveat. No false claim of SCL calibration.
  • PTP diagnostic clock lock: NOT MEASURED and packet observation explanation replaces the ambiguous UNVERIFIED (received PTP traffic is not proof of clock lock).
  • P1 visual consistency: 16/14 DIP hero/panel padding, unified inspector border and more subtle 9-DIP section-card radius.
  • GOOSE: concise no-event copy with capture-path caveat on hover; no blank publisher/network/dataset cards until an event is selected; show one actionable empty-state hint instead.
  • SCL: suppress three huge blank engineering tables when no SCL is loaded; show one centered concise import instruction; previously loaded stream catalog, binding matrix, full dataset and technical evidence retained.
  • No SV decoder, phasor or timing math modifications.

Gates

  • Windows WPF release build
  • Unit/regression tests
  • Runtime stability
  • CodeQL & dependency
  • Windows x64 candidate packaging
  • Manual visual check at 1600x900, 1366x768 and DPI 125/150% on Windows; cannot be certified by build alone.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T00:21:31.364973Z 06a5269 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06a5269393

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<Border Grid.Column="2"
Style="{StaticResource WorkspaceSegmentHostStyle}"
HorizontalAlignment="center"
HorizontalAlignment="Left"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the workspace rail clear of capture controls

At the default 1600-DIP window width—and more severely at the 1240-DIP minimum—the seven fixed-width workspace buttons require about 990 DIPs, but this star column receives only the space left after the product identity and roughly 560-DIP capture-control stack. Changing the rail from centered to left-aligned pushes its overflow entirely into column 3, where the later-declared adapter and run controls render and hit-test over the Validation and Advanced buttons. The new margin on the capture stack further reduces the star column rather than reserving space after the rail; this needs responsive button sizing/wrapping or a layout that actually allocates both groups their required widths.

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 1a312c4 into main Oct 18, 2026
7 checks passed
@masarray
masarray deleted the fix/p1-operator-clarity-header-goose-20261018 branch October 18, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant