Repository navigation
Fix operator navigation: five clean tabs, responsive header, specialist tools menu - #43
Conversation
…remove truncated SCL status pills
…and responsive 1240px header layout
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b0295fc15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <MenuItem Header="Validation" Tag="4" Click="WorkspaceToolMenuItem_Click" | ||
| ToolTip="Compare SCL engineering with live traffic"/> | ||
| <MenuItem Header="Advanced" Tag="6" Click="WorkspaceToolMenuItem_Click" | ||
| ToolTip="Raw packet decode, estimator and performance"/> |
There was a problem hiding this comment.
Add navigation regression coverage and documentation
This moves Validation and Advanced from first-level tabs into a new menu and changes the visible navigation state, but the commit updates only MainWindow.xaml and its code-behind. Add regression coverage for selecting indices 4/6 and returning to a primary tab, and update the operator documentation to describe the new route; repository policy explicitly requires both for runtime and user-visible changes.
AGENTS.md reference: AGENTS.md:L67-L67
Useful? React with 👍 / 👎.
| foreach (var tab in WorkspaceSegmentButtons.Children.OfType<RadioButton>()) | ||
| tab.Width = compact ? 94 : 112; | ||
|
|
||
| UpdateWorkspaceActivePill(animate: false); |
There was a problem hiding this comment.
Clear active animations before repositioning the pill
After any animated tab switch, both pill properties retain animations with the default FillBehavior.HoldEnd; crossing the 1450-DIP threshold then changes every tab's width and calls this non-animated update, but assigning the base X and Width values cannot override those active animations. Consequently, the highlighted pill can remain at its pre-resize offset or width until another tab is clicked. Remove the existing animations before applying the immediate values, or replace them with non-holding animations.
Useful? React with 👍 / 👎.
Why
Seven fixed-width primary tabs caused header overflow in Windows screenshots and introduced unnecessary cognitive load.
Changes
Acceptance gates