Repository navigation
Release automation: guarded public stable v1.4.0 approval trigger - #45
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a5781a034
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| push: | ||
| branches: [main] | ||
| paths: | ||
| - ".github/release/v1.4.0.approved" |
There was a problem hiding this comment.
The paths filter matches every change to this pathname, including edits and deletion, rather than only creation. If the initial release attempt fails and an operator removes the marker to revoke or clean up the approval, that removal starts another run which can publish the stable release unexpectedly. Inspect the change status or at least verify that the marker exists before dispatching.
Useful? React with 👍 / 👎.
| if gh release view v1.4.0 --repo "$GH_REPO" >/dev/null 2>&1; then | ||
| echo "already=yes" >> "$GITHUB_OUTPUT" | ||
| echo "v1.4.0 already published; skipping duplicate dispatch." | ||
| exit 0 |
There was a problem hiding this comment.
When a supported manual run of release-package.yml has already created v1.4.0 as a draft or prerelease, this lookup succeeds and sets already=yes, so stable approval silently skips publication. The checked gh release view documentation exposes isDraft, isPrerelease, and publishedAt, confirming that a successful lookup is not equivalent to an existing public stable release; inspect those fields and promote or replace non-stable records instead of treating them as published.
Useful? React with 👍 / 👎.
1 participant
Implements a narrowly scoped, idempotent, source-controlled public stable v1.4.0 release dispatch. No release happens merely from merging this PR. A follow-up approval marker
.github/release/v1.4.0.approvedadded on main will trigger exactly the existingrelease-package.ymlWindows Release build/test/ZIP verification workflow withpublish_release=true,prerelease=false,draft=falseanddocs/RELEASE_NOTES_v1.4.0.md. All normal code commits and tags retain existing behavior. Existing SCL source patch is already merged in #44 and candidate #158 passed 153 tests / packaging / code security. This PR only creates the minimum release-dispatch bridge; it does not bypass build or test gates.