Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline and exact identity
Stacked on combined FAT candidate #642 at
30a7f18e8e575604eb1306c96753daab9f9c4a51, notmain. Inherits ARIEC61850 engine #183 exactc85d4e20db722bd0c2729f2533b323b13d3ef735. No engine repin, command or report control mutation.Reproduction / root cause
IedBrowserReadPlan.Buildpreviously trustedpage.Payloadattributes in the DO/LN/DA branches, checking only allowed FC and nonempty MMS reference. After model/association rollover, a detached/stale UI node could supply an unrelated target or spoof its data type. Explicit SV/OR/BL reads must be authorized by the active live model, not by UI payload.Minimal correction
At read-plan creation, index exact (MMS reference, FC) pairs from the active model's permitted inventory. Re-resolve every selected payload through this catalog; use the catalog's type. Ambiguous duplicate identities fail closed instead of selecting whichever is first. No network I/O, caches, timers, writes, RCB enables or changes to passive focused-read policy.
Regression
P0HBrowserModelInventoryAuthorityTests: stale UI cannot inject OR/BL/CO targets; a forged type is ignored; wrong FC rejected; duplicate model identities fail closed; valid SV/OR/BL/ST remain readable. Existing Browser read coverage/negative tests still required.Qualification
CODE CHANGED, CI/FAT PENDING. Require exact-head Windows full CI and artifact packaging; then operator-only read-only FAT on authorized IED to prove scalar GVA/typed decode/ledger/UI. Do not infer physical success from regression tests. No main merge, no public release.