Repository navigation
P0 UI-2: remove persistent Command Dock focus border; unify discovery + Browser Read under-IP progress - #647
Conversation
… changing toggle behavior
…-IP progress line without changing MMS progress authority
…existing fixed thin under-IP progress slot
… one derived IED-card activity percent
…ned discovery and Browser Read lifetimes
…r on Browser Read
…-IP discovery progress
…ry, with other actions gate-owned
|
Disposition: Superseded (fully preserved UI checkpoint) — safe closure of intermediate historical PR tracking, not an application merge or release acceptance. Canonical replacement: #649 retains the cumulative field-accepted IED card/Command Dock UI ancestry; current #727/#729 integrated RC at Unique delta: Phase-2 discovery progress and Browser Read's non-layout-shifting under-IP indicator. Evidence: Both regression suites are byte-identical in RC: P0GBrowserSubstitutionReadAndIedCardProgressTests.cs and P109YTransparentDockAndDiscoveryProgressRegressionTests.cs. The latest MainWindow.xaml still has BrowserReadProgressLine in the fixed IED-card progress lane; MainWindow.xaml.cs still animates discovery only while IsDiscoveryProgressActive, and MonitorModels.cs computes IedCardProgressPercent without resetting the Browser Read progress. The original PR commit/branch remains recoverable, and original tests/checkpoints have not been deleted. Safety: The current RC production files evolved after the PR, so we verified surviving specific behavior, not falsely claimed blob-identical entire XAML/model files. This action changes no runtime code, no main, no stable v1.6.42, no ARIEC engine pin and no R7/R10 or physical FAT policy. Follow-up: Maintain exact distinct discovery and Browser Read progression and test compact-card geometry in current GUI/SSOT FAT; no merge of old presentation sources. Existing #649 and physically gated #729 remain OPEN. Do not revive/rebase older UI heads over current SSOT/Write/SMV. |
Base and scope
Stacked on Phase 1 PR #646 exact head
d14a6e309326f8c22e2d812f9fff29bef719eb80; original combined FAT/field checkpoints30a7f18e/de71a1a4remain untouched. UI Phase 2 only; no control command service, safety flags, ARIEC61850 engine, report/leaf model or deployment/main changes.Two verified presentation defects
HeaderFocusRing+IsKeyboardFocusedtrigger drawing#AAFFFFFFon the full header; remove both;FocusVisualStyle={x:Null}suppresses default focus chrome, preserving mouse/keyboard toggle and up/down glyphs.BusyOverlay, spinning 28px dial and separate 5px progress + text that covered card identity/actions, despite a permanent 7px line slot already beneath IED IP. Remove overlay and spinner entirely, keep card content and IP readable. Repurpose existing under-IP 3pxDiscoveryProgressBarfor discovery and Browser Read.Single source of progress truth
IedCardProgressPercentis a[JsonIgnore]derived presentation selection of existingDiscoveryProgressPercentandBrowserReadProgressPercent(no new counter). Per-IED discovery phase arm set by existingResetDiscoveryProgress, automatically disarmed whenIsBusy=false, avoids stale 100% on other busy operations.IsDiscoveryProgressActiveandIsBrowserReadingdrive opacity without changing 7px fixed geometry.Regression/release gates
Existing P0G fixed Browser Read slot regression updated for derived binding; new P109Y tests assert transparent focus, one shared progress, no spinner, independent device values, reset/retire/cycle and no stale re-arm. Require exact-head Windows build and tests + packaged native bridge + portable EXE smoke (then visual acceptance at 100%/150% DPI, browsing/discovery/reconnect on user setup) before merging/releasing. Do not claim relay acceptance from CI.