Skip to content

P0 UI Phase 3: integrate selected IED blue accent into rounded card edge - #648

Closed
masarray wants to merge 5 commits into
ui/command-dock-focus-discovery-line-20261020from
ui/ied-card-integrated-selection-phase3-20261020
Closed

masarray wants to merge 5 commits into
ui/command-dock-focus-discovery-line-20261020from
ui/ied-card-integrated-selection-phase3-20261020

Conversation

@masarray

Copy link
Copy Markdown
Owner

User screenshot / source-proven root cause

The detached blue line is produced by the active runtime P2 theme, not the inline XAML fallback: P2BlueSteelGreigeUx.ApplyMainWindow installs P2MainIedListItemStyle. That template drew SelectionRail at x=0 and shifted Card right by Margin="5,0,0,0", producing a visible empty gutter. This is why the blue line felt like a separate noisy object rather than part of the IED Card.

Phase 3 scoped fix

  • Remove 5px card gutter; render a narrow 3px SelectionRail OVER the same rounded card's left edge (x=0), vertically inset 8px to respect radius 10. Single card silhouette; selected/monitoring brushes retained; no layout reflow on selection.
  • Accent overlay explicitly IsHitTestVisible=False, Panel.ZIndex=1 and SnapsToDevicePixels/UseLayoutRounding for 100/125/150% DPI. Card padding, row heights, actions and hit areas remain.
  • Apply identical calm selection geometry to the independent FAT IED list style for visual consistency.
  • Preserve Phase 2 progress under IP (fixed 7px / line 3px), STOP preemption, no blocking discovery overlay, and all Command Dock states.
  • P109Z regression validates actual P2 runtime styles, border+accent geometry, state triggers, actions and progress invariants. Architecture/acceptance notes in docs.

Locked references and release gates

Parent Phase 2 exact green SHA f0831fa0a92f95340f5c03f4186f9412b6c5e7ff pinned as checkpoint/arsas-phase2-ui-green-20261020; original combined command+leaf FAT and field checkpoints also preserved. Only resource XAML, test and documentation changed. Windows WPF compilation, engine/consumer tests, native CTest, packaged smoke and 100/125/150% DPI visual acceptance are required. No ARIEC61850 engine modification, command, leaf or protocol operation change; no main merge or public release.

Copy link
Copy Markdown
Owner Author

Field acceptance 2026-10-20: user confirmed integrated blue selection rail on Phase 3 ARSAS portable build source SHA 109b1f93eea0ddd47858c6e0ba6fd6ed9d54bb6f (run 39428581363, source-tree identical to tested merge 36568539). Frozen as checkpoint/arsas-phase3-bluebar-accepted-20261020; do not force-update. Subsequent independent functional regression PR #649 stacks on this exact UI head: it restores selected ZIVAVR StatusOnly CO roots to the Command Dock without granting Operate, preserves single exact ctlModel CF Write+readback commissioning, and disables per-IED GOOSE card buttons without GoCB inventory. CI/FAT pending; no main merge or UI-phase3 rework.

Copy link
Copy Markdown
Owner Author

CROSS-THREAD P0 ANTI-REGRESSION LOCK (user accepted 2026-10-21 WIB)
Canonical accepted source SHA: 5a33fb101026707caf6410ff097a569cfabf3939, frozen branch checkpoint/arsas-ctlmodel-glyph-command-stable-20261021. Windows CI #39499030618 success (11 workflows, 2,425 ARSAS+24 engine+6 package, native and portable smoke), artifact #12298499086.

Every concurrent leaf-data / engine / command / UI thread MUST read canonical engineering handoff #651 before overlapping edits, rebases, or promotions. Preserve exact selected CO inventory separately from physical operability; ctlModel icon+caption always present (declarative, virtualization-safe); per-IED GoCB gating; stable Command Dock and blue flush IED Card selection/progress; typed runtime safety and zero-reset fast path. Keep checkpoint SHA intact; do not replace the approved baseline with stale main, do not merge to public release without exact-SHA CI and field review. This is a traceable process lock, not a claim of enforced GitHub branch-protection ruleset.

Copy link
Copy Markdown
Owner Author

Disposition: Superseded (fully preserved UI checkpoint) — safe closure of intermediate historical PR tracking, not an application merge or release acceptance.

Canonical replacement: #649 retains the cumulative field-accepted IED card/Command Dock UI ancestry; current #727/#729 integrated RC at 817c3910e8223fa2ac531a4426ada5d2d4bbbe50 retains the relevant code behavior. Original PR head 109b1f93eea0ddd47858c6e0ba6fd6ed9d54bb6f is an exact ancestor of the RC (GitHub compare ahead=793, behind=0).

Unique delta: Phase-3 integrated selected-IED blue accent on the card's rounded left edge. Evidence: The original ARSAS_UI_PHASE3_INTEGRATED_IED_CARD_2026-10-20.md and P109ZIntegratedIedSelectionCardRegressionTests.cs have byte-identical RC blob hashes. The currently active Resources/P2BlueSteelGreige.xaml P2MainIedListItemStyle still uses one continuous rounded Card silhouette (no 5px detached card gutter) and an IsHitTestVisible=False SelectionRail overlay painted directly on the border with no measure-width impact. The original PR commit/branch remains recoverable, and original tests/checkpoints have not been deleted.

Safety: The current RC production files evolved after the PR, so we verified surviving specific behavior, not falsely claimed blob-identical entire XAML/model files. This action changes no runtime code, no main, no stable v1.6.42, no ARIEC engine pin and no R7/R10 or physical FAT policy.

Follow-up: Preserve the accepted card accent and single-silhouette behavior during premium cool-blue theme integration #730/#732. Existing #649 and physically gated #729 remain OPEN. Do not revive/rebase older UI heads over current SSOT/Write/SMV.

@masarray masarray closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant