Repository navigation
FAT Write UX: typed inline value editor and fixed Write action - #712
Conversation
…eserve exact GVA/write admission
…riven boolean picker
…Scout-like editor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5a9739db8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| attribute.MmsReference, attribute.FunctionalConstraint); | ||
| ReferenceLabel.Text = $"{_device.Name} • {_reference.Domain}/{_reference.Item} [{_reference.FunctionalConstraint}]"; | ||
| ReferenceLabel.Text = $"{_device.Name} • {_reference.Domain}/{_reference.Item}"; | ||
| AttributeLabel.Text = _reference.Item.Split(' |
There was a problem hiding this comment.
Every build containing this commit fails to parse because this assignment ends inside an unterminated character literal; the intended LastOrDefault() suffix appears after the class closes at line 216, followed by a duplicate of the old implementation. Restore the complete display-name expression and remove the duplicated trailing implementation so the application can compile.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
| { | ||
| Reference = reference; | ||
| ReferenceText = referenceText; | ||
| DisplayName = referenceText.Split(' |
There was a problem hiding this comment.
Every build containing this commit also fails to parse this file because the DisplayName assignment begins an unterminated character literal and prematurely abandons the constructor; its intended suffix and the duplicated former class body occur after the new class has already closed. Complete the expression and remove the duplicated tail so the project can build.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
| IedBrowserWriteButton.Content = ctlModel is not null ? "Write ctlModel…" : | ||
| selectedDo is not null ? "Write DAs…" : "Write DA…"; | ||
| // Stable toolbar footprint. Context belongs in tooltip / editor, never caption. | ||
| IedBrowserWriteButton.Content = "Write"; |
There was a problem hiding this comment.
Whenever browser button state is refreshed—including through RefreshIedBrowserReadButtons—assigning this string replaces the StackPanel content declared for IedBrowserWriteButton in MainWindow.xaml, so the newly added Material pencil disappears after initialization or a selection change. Keep the composite icon-and-label content intact while updating only the enabled state and tooltip.
Useful? React with 👍 / 👎.
…aterial Write visual
…aterial Write visual
masarray
changed the title
masarray
changed the title
4b3804f
into
fix/fat-integrated-quality-attention-20261022
Improves ARSAS Browser Write based on physical FAT feedback. Compact Name/Value grid, Boolean picker from exact live GVA, current-value prefill for numeric/text inputs, compact batch edit. Toolbar label stays Write and uses user-requested vector pencil. Native GVA, admission, confirmation and readback remain unchanged. Dedicated ctlModel editor preserved. Validate Windows CI prior to FAT merge.