Skip to content

P4 website: bilingual EN/ID navigation and accessible mobile menu - #748

Merged
masarray merged 4 commits into
mainfrom
docs/p4-bilingual-nav-accessibility-20261025
Oct 25, 2026
Merged

masarray merged 4 commits into
mainfrom
docs/p4-bilingual-nav-accessibility-20261025

Conversation

@masarray

Copy link
Copy Markdown
Owner

Public website P4 closure — bilingual navigation and accessibility

  • Actual issue: shared header text, Skip-to-content, language switch and mobile navigation accessibility labels were English on Indonesian pages despite localized page copy.
  • Use the already supported CSS data-lang contract for proper language-aware visible navigation with correct localized destinations (Beranda, Belajar, Panduan, Unduh) and EN/ID switch.
  • Localize accessible menu open/close/primary navigation names using HTML document language; connect menu button and nav with aria-controls.
  • Handle taps on spans nested inside localized navigation links, so mobile menu closes correctly.
  • Add exact-source .NET regression assertions to stop navigation localization rollback.

Safety: website/header/app.js and regression tests only. Does not modify app runtime, pinned IEC engine, release assets, v1.6.42 tag or source-promotion gate #729.

Merge only after exact-head Build ARSAS and Pages validation succeed, followed by deployment confirmation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T10:17:06.314879Z 246133c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Cross-thread checkpoint — ARSAS public-product closure (2026-10-25)

Completed and merged prior to this PR: P0/P1 release v1.6.42 public synchronization #742 and screenshots/onboarding #743; P2 portable EXE contract, media metadata check, legacy publisher fail-closed and sitemap freshness #744; P5 beginner-first README and archived milestone history #746. main was 30012bde34dd77d53406aa5d8007d3729a3614c5 before this PR.

This PR #748 fixes the additional P4 EN/ID shared-navigation and mobile-menu accessibility issue on exact head 246133cdef8b0b85f960ba685dbca3e0a2b278bd. Do not treat an open PR or in-progress CI as merged. Merge only on full exact-head green checks.

Unresolved and intentionally tracked:

Immutable boundary: published v1.6.42, installer/portable/checksum/SBOM and release evidence are NOT modified by these website/README PRs. Stable download source = release tag; main application VERSION can remain 1.6.41 until gated promotion. Avoid restoring old screenshot hero, Portable ZIP, or old README milestone clutter.

Thread may be closed after this PR is merged and verified on production; unresolved issues and #729 are durable follow-on work, not falsely completed.

@masarray
masarray merged commit 4c8afa3 into main Oct 25, 2026
25 checks passed

Copy link
Copy Markdown
Owner Author

FINAL THREAD CLOSURE CHECKPOINT — 2026-10-25, GitHub-verified

Public Product phase engineering changes are merged and deployed.

Deliberately open follow-ups (NOT completed)

  • #745 independent human pixel-level screenshot/privacy disclosure review; metadata CI != pixel safety.
  • #747 two real v1.6.42 Quick Start setup screenshot captures (historical v1.6.40 currently labeled truthfully).
  • #749 GitHub About/topics admin update and protection-relat typo; not writable through GitHub app connector.
  • #750 real mobile/device, keyboard/screen-reader and measured Core Web Vitals acceptance; CI does not certify this.
  • Draft #729 is separate app-source promotion blocked by independent R7/R10 qualification. Do not merge because product Pages is green.

Disposition: The GitHub-controlled public-product implementation in this conversation is completed and has a merge/deployment checkpoint. This chat can be safely closed without loss of actionable backlog. Do not represent the four outstanding human/admin QA issues or application source-promotion physical gate as completed. Future threads should resume from main plus these issue/PR links rather than redoing P0–P5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant