Repository navigation
P4 QA: exercise public EN/ID website in real Chromium at mobile and desktop widths - #751
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b2cdbd00b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| page.locator("nav[data-nav-links] a[data-nav-page='capabilities'] span[data-lang='" + lang + "']").click() | ||
| if page.url.split("?")[0].split("/")[-1] != "features.html": | ||
| errors.append("nested localized navigation click failed") | ||
| if page.locator("button[data-menu-toggle]").get_attribute("aria-expanded") != "false": | ||
| errors.append("nested link did not close menu") |
There was a problem hiding this comment.
Assert nested-click menu closure before leaving the document
If the nested-label click handler in landing/app.js regresses or is removed, this check still passes: the link navigates to features.html, and the subsequent locator reads the new document's toggle, whose initial markup already has aria-expanded="false" in landing/partials/header.html. Consequently, the reported nested-click regression coverage never verifies that the originating menu actually closed. Prevent the default navigation for this interaction check and assert closure on the original document, then test the destination separately. This is the exact interaction behavior that the repository's regression guidance requires protecting.
AGENTS.md reference: AGENTS.md:L176-L180
Useful? React with 👍 / 👎.
…hout CI-sprawl increase
FINAL P4/P6 public-product implementation checkpoint — 2026-10-25 (after real deployment)PR #751 MERGED into main as
Still open, not claimed closed: #745 owner network-data disclosure decision, #747 authentic v1.6.42 Add IED/Smart IP screenshots, #749 repository About/topics admin edit (no connector write), #750 actual device + screen reader + measured field Core Web Vitals signoff, and independent physical R7/R10 on draft #729 app source-promotion. Do NOT weaken guards, repoint tag or overwrite binary assets to make a progress report look fully closed. This branch is finished, merged, deployed, and CI-qualified within its defined website engineering scope; further work should use main + existing tracking issues. |
P4 Website real browser QA — headless Chromium
Closes only the automated browser-smoke subset of #750. Existing source validators already check 62 pages, sitemap, links and image metadata.
Important limitations: headless Chromium is not real-device iOS/Android, screen-reader QA, certified WCAG, Lighthouse or real CrUX Core Web Vitals. Issue #750 stays open for remaining physical/device QA.
Image disclosure #745, current Add-IED and Smart IP captures #747, repository About/topics #749 and gated source PR #729 remain separate and cannot be auto-closed.
Merge only if new Chromium CI and existing required application/site exact-head checks are green.