Repository navigation
P0 #707: independent exact RCB setup-vs-traffic evidence in Copy Diagnostic - #762
Merged
masarray merged 6 commits intoOct 28, 2026
Conversation
masarray
marked this pull request as ready for review
October 28, 2026 00:00
masarray
merged commit Oct 28, 2026
833dbe3
into
release/arsas-integrated-rc0-20261024
19 of 20 checks passed
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 SG7 reporting: preserve true per-RCB setup write evidence, including zero-frame paths
Confirmed causal observability gap (existing operator evidence)
SG7_BCU was field-tested 77/77 and 4/4 routed RCBs on Oct 24–25, but 28 Oct recurrence showed 56/77 and 1/4, despite identical pinned engine and reporting source. The October diagnostic shows all four StartConfiguredStaticReportMonitor attempts returned success, but A01 alone had a received Report. Do not equate successful Start/RptEna/GI write with traffic proof.
Current ARSAS already captures ARIEC
NativeReportMonitorStartResult.RptEnaWriteAccepted,GeneralInterrogationWriteAccepted, andActivationReturnedAtUtcinto the session'sReportActivationByPlanId. HoweverProcessReportHealthcreatesReportStreamsonly after a routed frame. Thus the new merged #761 Copy Diagnostic incorrectly showsunverifiedwrite evidence for all zero-frame RCBs even when the engine had a concrete result.Scope (6 files, no network behavior change)
Iec61850RcbActivationEvidence(native write result, not readback or actual Report).device.RcbActivationEvidenceper current association, published only after a completed setup attempt, bounded to 64 plan IDs, cleared on start/stop/reconnect.activationCall=success/failed/unknown,setupRptEnaWrite,setupGiWrite,activationReturnedUtcfrom actual ReportFrames, GI frame reason, and value completeness. Ambiguous/wrong-DataSet/old-association proofs remain unknown.Explicit non-goals / safety
No new IEC 61850 MMS reads/writes, no GI retransmit, no dynamic DataSet changes, no retry or cyclic polling, no receive scheduler or projection changes, no Command/Write UI changes, no ARIEC pin repin, no main/stable publishing, no claim that #707's 21 missing process values have been restored or that 4/4 RCBs were received in the failed session. Operator FAT evidence does not need to be re-captured to validate this diagnostic change.
Based exactly on integrated RC
e7b1943792488af4a4dd03841c39abfe017f121a. Kept DRAFT until current-head Windows Build + app test pass and review.