Repository navigation
M2L: canonical measurement semantics and received-source provenance for native inspector - #178
Merged
masarray merged 4 commits intoOct 15, 2026
Conversation
masarray
marked this pull request as ready for review
October 15, 2026 07:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e53de4aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline and dependency
0cc882022d20f416a33433d5f29a1f8950984d85(M2K PR M2K: ARSAS-style native All-IED live grid with Quality/IED Time and canonical read state #176 safely squash-merged).MmsLiveTreeModel, Data Model native inspector, existing 60k+ large-model QA. No firmware, Studio, MMS decoder duplication, SCL parser fork, timer or polling.0dc048bb9ea33676a64e8284ca3626d70f2bf684; current exact head:278271d7ca316d154113c1c8968339eea3a83e94.Root cause
Generic DO child preview had no explicit displayed-value source or received provenance; companion q/t looked up same-DO siblings without matching FC. Inspector had no guard against casually treating a scalar as an angle-bearing phasor.
Implementation
CMVstructuredcVal.mag.f/iandcVal.ang.f/i, or scalarMV/SAVnumericmag.f/i/instMag.f/i; only actual received finite numeric MX leaf values. Exact IEC alias lookup reuses existingreferenceIndex_(bounded per-candidate work; no O(all DO children) scan per displayed DA).HzandTotWremain scalar even if a strayang.fexists. No inferred multiplier, unit, or degree symbol.Regression
Extended
ied_browser_large_model_qawith: missing phasor sample; partial phasor; invalid angle; vector+angle; same-DO wrong-FC Quality; correct Quality/Timestamp; Hz/TotW stray-angle suppression; Boolean non-measurement; untrusted CDC suppression; source-replacement evidence reset; received-empty DO source; integerCMVvector andSAVscalar alternatives.CI & gates
Do not merge while draft/CI pending. Require exact-head native Qt build, 60k regression, Browser convergence, review + post-merge verification. Post-M2K main CI is separately pending and must be checked. No physical-IED/Windows installer claim.
Updated review checkpoint
278271d, new positive and negative QA added; inline review thread resolved only after source fix.