Skip to content

M2L: canonical measurement semantics and received-source provenance for native inspector - #178

Merged
masarray merged 4 commits into
mainfrom
feat/workbench-m2l-measurement-provenance-20261015
Oct 15, 2026
Merged

masarray merged 4 commits into
mainfrom
feat/workbench-m2l-measurement-provenance-20261015

Conversation

@masarray

@masarray masarray commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Baseline and dependency

  • Base: main 0cc882022d20f416a33433d5f29a1f8950984d85 (M2K PR M2K: ARSAS-style native All-IED live grid with Quality/IED Time and canonical read state #176 safely squash-merged).
  • Scope: canonical MmsLiveTreeModel, Data Model native inspector, existing 60k+ large-model QA. No firmware, Studio, MMS decoder duplication, SCL parser fork, timer or polling.
  • Initial implementation: 0dc048bb9ea33676a64e8284ca3626d70f2bf684; current exact head: 278271d7ca316d154113c1c8968339eea3a83e94.

Root cause

Generic DO child preview had no explicit displayed-value source or received provenance; companion q/t looked up same-DO siblings without matching FC. Inspector had no guard against casually treating a scalar as an angle-bearing phasor.

Implementation

  • Local, bounded measurement map on existing canonical DO/DA nodes (no new semantic/cache owner).
  • Only trusted/exact CDC: CMV structured cVal.mag.f/i and cVal.ang.f/i, or scalar MV/SAV numeric mag.f/i / instMag.f/i; only actual received finite numeric MX leaf values. Exact IEC alias lookup reuses existing referenceIndex_ (bounded per-candidate work; no O(all DO children) scan per displayed DA).
  • Hz and TotW remain scalar even if a stray ang.f exists. No inferred multiplier, unit, or degree symbol.
  • Exposes per-field exact MMS source reference; values and angles remain absent until received. Selected DA's Quality/Timestamp now limited to received companion from same FC.
  • Existing DO selected-value preview reports the source DA and uses its actual sample bit (including received empty strings).
  • Native QML selected attribute inspector presents these fields explicitly.

Regression

Extended ied_browser_large_model_qa with: missing phasor sample; partial phasor; invalid angle; vector+angle; same-DO wrong-FC Quality; correct Quality/Timestamp; Hz/TotW stray-angle suppression; Boolean non-measurement; untrusted CDC suppression; source-replacement evidence reset; received-empty DO source; integer CMV vector and SAV scalar alternatives.

CI & gates

Do not merge while draft/CI pending. Require exact-head native Qt build, 60k regression, Browser convergence, review + post-merge verification. Post-M2K main CI is separately pending and must be checked. No physical-IED/Windows installer claim.

Updated review checkpoint

  • Codex P2 integer AnalogueValue review corrected at 278271d, new positive and negative QA added; inline review thread resolved only after source fix.
  • Predecessor M2K main exact-head SCL, Qt and Release Hardening verified SUCCESS. M2L own exact-head CI remains IN PROGRESS; no completion claim until success.

@masarray
masarray marked this pull request as ready for review October 15, 2026 07:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T07:37:59.050966Z d0e53de Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0e53de4aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 9cc9bda into main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant