Skip to content

M2M: native FCDA inspector parity, repository naming hygiene and C++ engine port map - #179

Merged
masarray merged 11 commits into
mainfrom
feat/native-workbench-reference-hygiene-arsas-parity-20261015
Oct 15, 2026
Merged

masarray merged 11 commits into
mainfrom
feat/native-workbench-reference-hygiene-arsas-parity-20261015

Conversation

@masarray

Copy link
Copy Markdown
Owner

Baseline and scope

Based on main c8aabf292c370993950b8682718cd56b77f2cabf; Workbench is native Qt/QML apps/ied_simulator, not the separate ESP32-P4 Studio GUI. Source references inspected: ARIEC61850 main e5deed1 and ARSAS main 45348ec.

1. Repository naming hygiene (hard requirement)

  • Neutralize a prohibited external-client product name throughout existing tracked C++/Python/docs, including test identifiers and golden output labels. Preserve BER/MMS data vectors and test assertions.
  • Remove hard-coded source/device branding in indexed RCB QA: validate four ordered concrete indexed RCB instances using their actual common LLN reference, effective ReportID, probe evidence and bound DataSet.
  • Add tiny PR/main GitHub Actions Product Naming Guard scanning tracked text and filenames, fail closed on recurrence.

2. Real native Workbench UX vertical slice

  • DataSets selected DA evidence pane appears for every canonical selected DA, not only q/t leaves.
  • Show FC, actual received/read state, current value, Quality, IED Timestamp, MMS type and exact value source from existing MmsLiveTreeModel, bounded and read-only.
  • Render clear NOT READ for unreceived DA and lazily expanded member attributes.
  • Extend existing Browser convergence contract. No alternative MMS engine, no background poll, second parser, new cache, or WPF port.

3. Forward engineering boundary

  • docs/ARIEC61850_ARSAS_NATIVE_PORT_MAP.md maps upstream reference engine and Explorer interaction to existing C++/Qt owners and remaining evidence-based gaps. This is an adaptation, not a second runtime.

Acceptance

  • Naming CI, native Qt full build/Browser/large-model/routing QA, review and exact-head CI must pass before merge.
  • Additional rendered selected DataSet/DA screenshots and physical IED/Windows installer parity are not claimed by this slice.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T09:11:33.573951Z cc213a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc213a19a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check_product_naming.py
Comment thread apps/ied_simulator/test_browser_convergence.py Outdated
Comment thread apps/ied_simulator/src/ied_report_workspace_qa.cpp Outdated
@masarray
masarray merged commit ce643e8 into main Oct 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant