Skip to content

fix(studio): one-click copyable field diagnostics and truthful flash verification result - #186

Merged
masarray merged 4 commits into
mainfrom
fix/studio-copy-diagnostics-flash-result-20261016
Oct 16, 2026
Merged

masarray merged 4 commits into
mainfrom
fix/studio-copy-diagnostics-flash-result-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Physical evidence (16 October 2026)

Operator ESP32-P4 is connected and reports RUNNING; flash writer succeeded, exact-build reconnect verification returned an ambiguous popup. The physical PCAP confirms 40,171 canonical ARSTACK_SV01 frames / 10.043 s with zero smpCnt discontinuities; the intentional AR_DIAG_SV1 lab mirror is another 40,170 frames. PCAP is NOT committed per repository data rules.

Changes

  • Persist the specific supervisor failure reason even after an optional update falls back to compatible READY (no more stale firmware-worker reconnecting text in the failure dialog).
  • Add operator-triggered Copy diagnostics in Advanced > Firmware and Device diagnostics, containing current/bundled build ID, compatibility/exact match, serial session owner, firmware stage/result, profile status, SV/PTP telemetry and bounded device/firmware logs.
  • Explicitly label device data as reported, not independent wire/timing proof; user reviews/redacts before sharing.
  • Add deterministic harness regression for preserved failure/diagnostic evidence.

Safety

Diagnostic snapshot is read-only; single serial/firmware owner unchanged. No firmware packet layout, PTP, or public release changes. Draft pending CI review and physical retest.

@masarray
masarray marked this pull request as ready for review October 15, 2026 23:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:55:01.838780Z a571abb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a571abb35b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/arstack_studio/src/SmartSessionController.cpp Outdated
Comment thread apps/arstack_studio/src/SmartSessionController.cpp Outdated
@masarray
masarray merged commit ef630e6 into main Oct 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant