Repository navigation
fix(studio): legible native PTP/smpSynch selectors and honest simulation feedback - #193
Conversation
…d-command feedback
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8e86c998c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2026-10-16 merged implementation & Windows lab handoffMerged: PR #193 to main Functional correction over merged PR #192: shared Qt Quick One real user artifact: Native Preview Actions run https://github.com/masarray/arstack61850/actions/runs/38880181755, artifact Physical acceptance remaining: installer app/desktop icon appearance, dark dropdown popup on real user's Windows theme, right-click angle Equal/Balance and value Equal ABC (from merged PR #192), PTP Source/Follower lab behavior, AUTO vs forced smpSynch confirmation and Copy diagnostics. Observed PTP TX is not proof of SMP counter hardware epoch alignment or IEC 61850-9-3 qualification. |
Why this follows already-merged PR #192
The user specifically reported dark Windows native controls showing unreadable black text and asked for convenient lab PTP / SV simulation. PR #192 implemented the core workflow, but its SV smpSynch ComboBox retained Windows native content/popup delegates. Depending on platform style, its dark panel still could show black text. Additionally the selection handler ignored a rejected
requestSmpSynchreturn value, falsely leaving the new selection apparently active.Changes (real source code, not a UI mockup)
StudioDarkComboBox.qml(QML-only presentation component) with explicit high-contrast selected text, indicator, focus border, options, popup and disabled state.smpSynchModeand show an actionable error. Copy diagnostics remains next to the controls.Invariants
PTP state machine/firmware timing/SV sampling and packet hot paths untouched. This is a lab simulation tool; preserve explicit on-wire flag choices and never claim PTP–SV lock from the operator override. Stable v0.1.1 and Draft M3 PR #166 remain untouched.
Validation gates
Await native Qt QML compilation, Windows lifecycle, full Inno installer preview, and other required checks before merge. Physical Windows appearance and board retest outstanding.