Repository navigation
P0: opt-in negotiated MMS NameList wire pipeline with exact response routing - #197
Merged
Merged
Conversation
…d fail-closed receipts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4913873a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 milestone: bounded, negotiated wire-level GetNameList pipelining (opt-in)
Baseline
main bcbebc32ad19836cfd79ab05c1dec73e295b8721. Builds on merged #185 (measured wire budget) and #187 (orphan invoke-ID fail-closed). No existing concurrent dispatcher, no additional receive threads, no duplicate MMS client, no rewrite.Root cause and implementation
Serial
exchange_confirmedwaits for every response before the next independent per-domain NameList request. Actual MMS Initiate-Response can strictly negotiatemaxOutstandingCalling > 1; today this remains unused. Naively multithreading calls would race socket receive and COTP reassembly.exchange_confirmed_batchis a single association-owned synchronous dispatcher: validate every confirmed P-DATA + unique invoke ID and verified negotiated calling window before sending, serialize complete MMS/COTP sends, receive from the one authoritative socket, route interleaved InformationReports, accept out-of-order confirmation by exact registered invoke-ID, reject unregistered/duplicate/stale responses, and return deterministic input-order results.std::async, concurrent sockets, arbitrary sleep or cyclic Read.MmsLiveDiscoveryClientintroduces optional bounded domain/class GetNameList chains; each chain's continuation pages remain sequential and preserve exact case-sensitive identifiers, name order, bounds and failure evidence. Unattempted/unverified pages are never fabricated. Serial is unchanged by default; unknown peer capabilities safely fall back to serial.ariec61850_live_discover <host> --name-list-window 4(valid 1..8, default 1). Workbench and other existing consumers retain serial mode by default.Negative and parity regression
Acceptance gates
Require exact-head completed C++ CI (GCC/Clang/MSVC), native Workbench, SCL-assisted, protocol/security and Product Naming Guard, plus review-thread clearance. Do not merge pending/skipped checks. Physical IED acceptance, Windows installed Workbench acceptance, and measurable speedup remain separate gates.
Known unrelated current
mainIED Simulator Release Hardening failure: Windows NSIS Chocolatey feed HTTP 503 on dependency retrieval, before build, not evidence of protocol regression; distinguish infra from actual build/test failures.