Repository navigation
RC1 F4 field kit: restore Windows package contract and fail-closed trace provenance - #217
Conversation
…rkbench source SHA
…nch prerequisites
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fc5f4948b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed both exact-head review findings at |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Root cause / baseline
The legacy F4 Real IED Acceptance Kit workflow still called
packaging/windows/verify-release.ps1with the pre-PR #216 signature (missing-PortablePathand-ExpectedSourceSha). It also invoked NSIS without required/DAPP_ICONand never shipped aBUILD_HEAD.txtinside the staged installer/portable application. F4 ran only on a stale feature branch or manual dispatch, so release-package CI was green without proving the separate F4 kit could still build.The original evidence collector accepted
buildHead=unknown, captured any endpoint sharing TCP/102, and had no installed-Workbench-vs-kit SHA check. That can misattribute traffic/build provenance during actual field acceptance.Changes
mainF4 artifact publication; retain explicitworkflow_dispatchfor all other source changes.BUILD_HEAD.txt; supply actual favicon define and call source-matching Windows verifier with portable ZIP and SHA. F4 acceptance kit copies the already checked staged BUILD_HEAD instead of independently inventing provenance.Scope and risks
No MMS/GOOSE protocol engine changes, no automation of relay Writes, no user-facing GUI redesign. PCAP remains MMS-only; the canonical GUI/GOOSE/relay acceptance matrix remains separately required. All F4 green workflow results are CI and synthetic fixture evidence, not live vendor hardware certification.
Gate
Exact-head F4 Linux and Windows jobs, Qt/naming/routing checks as triggered, clean review, merge. Re-run post-merge main F4 and require source-matching installer, portable, and complete F4 artifact before claiming RC1 field kit ready.