Repository navigation
ux(studio): finish Paket A density and single-source status on native SMV workspace - #218
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6c1ae701e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SplitView.preferredHeight: 238 | ||
| SplitView.preferredHeight: 225 | ||
| SplitView.maximumHeight: 265 | ||
| SplitView.fillHeight: false |
There was a problem hiding this comment.
This DockFrame already binds SplitView.fillHeight: true on line 1108, so adding a contradictory second binding here makes Main.qml invalid; the waveform frame has the same duplicate binding on line 1152. Qt classifies a property bound multiple times as a duplicate-property-binding, which can prevent the main component from loading. Replace the existing bindings rather than adding second assignments.
Useful? React with 👍 / 👎.
| // The only global PTP/device status lives in the footer. | ||
| // This is an action strip, not a second diagnostic/status card. |
There was a problem hiding this comment.
When a verified device lacks PTP support, or while ptpStarting is true but ptpRunning is still false, the footer continues to render PTP OFF; this patch removes the badge that distinguished PTP UNAVAILABLE, PENDING, and UNVERIFIED. Consequently, an asynchronous start or failed/unverified transition is presented as an ordinary stopped state even though the controls are disabled. Move those state distinctions into the footer before removing the badge.
Useful? React with 👍 / 👎.
1 participant
Paket A · final focused operator UX cleanup
The main branch already contains most of requested Paket A from parallel work: a tall icon-over-caption Material ribbon, white-hover/dark-foreground tokenized
RibbonAction, 212px compact keyboard-accessible popup, a polished footer, NOApply to boardbutton, and one-click physical START viaSmartSessionController::requestStartWithScenario. This PR deliberately does not reinvent or remove those features.Remaining visual issues addressed (single atomic source commit
f6c1ae701e0f1b4e63bb8ae6d970b4336f571d86)preferredHeight: 225,maximumHeight: 265,fillHeight: false. The waveform dock flexes into the available space so the phasor does not become a tall mostly empty rectangle.TIME SYNC / SV SIMULATIONbanner and second PTP state badge with one compact 57px control strip. Global status stays in the polished footer, including offline/no ESP32 and PTP/smpSynch; settings stay in Advanced.Fast workflow and safety invariants (verified in repository before patch)
Apply to boardtext andrequestApplyDraft()are explicitly prohibited by the preexisting structural test.CI discipline
One small GUI-only commit, no redundant manual re-runs. Require exact-head Qt/QML including zero runtime binding exceptions, Windows lifecycle and geometry at 100/150/175% DPI, and RC2/naming routing where triggered. Merge only after required green gates. Physical real-board and on-wire SMV acceptance are distinct from CI.