Repository navigation
M3E.3: fail-closed SOURCE readiness on STOP, TX faults and boot ambiguity - #223
Conversation
ba3d6c3
into
feature/esp32p4-smv-ptp-epoch-binding-m3c-20261015
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7472f6918c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SOURCE_INVALIDATION = re.compile( | ||
| r"\bPTP (?:stop requested|start rejected|status unavailable)\b") |
There was a problem hiding this comment.
When a qualified source later emits the firmware's asynchronous PTP TX failed (...) warning from embedded/esp32p4_smv_injector/main/ptp_lab_task.cpp:763, this pattern does not match it and the log need not contain another PTP status= line. A capture ending at that fault therefore retains last_ready=True and sourceTxFaultObserved=False, returning OBSERVED, even though the same failure would veto qualification if a subsequent SHOW exposed its incremented TXfail; latch this native fault event as well.
AGENTS.md reference: AGENTS.md:L11-L16
Useful? React with 👍 / 👎.
| identity_lines = [line for line in lines if IDENTITY.search(line)] | ||
| boot_ids = [m.group(1).lower() for line in identity_lines | ||
| if (m := BOOT_ID.search(line))] |
There was a problem hiding this comment.
identity_lines includes only lines that already satisfy IDENTITY, whose regex requires a valid build field. Consequently a later boot's truncated identity or the real firmware message ARSTACK identity unavailable: ... from embedded/esp32p4_smv_injector/main/live_control.cpp:234 is ignored; a preceding valid boot ID followed by that event and a new clean SOURCE status still returns OBSERVED. Detect all ARSTACK identity events first and require each one to contain the expected build and boot ID so evidence cannot cross an unidentified boot.
AGENTS.md reference: AGENTS.md:L11-L16
Useful? React with 👍 / 👎.
1 participant
Root cause
M3E.2 SOURCE lifecycle checks accepted any historical
PTP status=RUNNINGwith positive Announce/Sync/FollowUp counters. STOP, rejected START, unavailable/truncated status, or TX failure after an earlier RUNNING could incorrectly remainOBSERVED. Missing boot IDs on later IDENTIFY lines were also ignored.Fix
Host-only evidence hardening; no firmware, Studio, PCAP decoder or receiver behavior changed. The experimental stack remains Draft. Independent PTP phase/egress/IED physical evidence is still missing and
smpSynch=AUTOmust remain unqualified.Exact code commit:
bdaf84c1fe333eb88f0a025d290a2f0bbd0a52d2.