Repository navigation
M3C.5: qualify SMV AUTO local synchronization using PTP phase + hardware MAC evidence - #232
Merged
Conversation
…ith loss revocation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
masarray
merged commit Oct 17, 2026
bc7f5c2
into
feature/esp32p4-smv-ptp-epoch-binding-m3c-20261015
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause and operator goal
The firmware's SV AUTO phase-valid gate was permanently false; even a correctly disciplined sample clock could never advertise a measured
smpSynch=1. Operators need direct PTP On → SMV Start for vendor-neutral IEC 61850 relay testing, not dialogs or manual flag workarounds.Change
SvLocalSyncEvidenceGate: canonical SV hardware descriptor timestamps must remain coherently near integer PTP seconds across two adjacent 16-second comparisons (three actual observations), within ±4µs, with matching source/session/fault generations, no missed slots or stalled descriptor.smpSynch=AUTO: qualify local value 1 only when the measurements support it; revoke on STOP, PTP role change/stop, failed canonical TX, missed samples, discontinuity, stale evidence and loss of software phase.Validation contract
CI PTP Core GCC/Clang/MSVC; guarded ESP32-P4 SOURCE (phase servo + sparse hardware stamp enabled, broadcast mirror OFF), RECEIVER and default SMV build. This is an experimental M3 branch. The 4µs software/egress admission values are conservative implementation thresholds, not a universal standards tolerance. Without physical MAC phase measurements no claim that these gates can actually promote on a board, nor an alarm-free SIPROTEC relay. No vendor-specific wire hacks and no new GUI warnings or dialogs.