Repository navigation
Studio UX P0: commit visible phasor before SV START; fix density, branding and controls - #243
Conversation
…before START snapshot
…box hover geometry
…box hover geometry
…box hover geometry
…box hover geometry
… and consistent hover
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7e708eb24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| require("Layout.fillHeight: true" in main_qml | ||
| and "Layout.maximumHeight: root.compactLayout ? 352 : 384" not in main_qml | ||
| and main_qml.index("id: voltageMatrix") < main_qml.index("id: currentMatrix"), |
There was a problem hiding this comment.
The new flexible-height assertion contradicts the existing check at lines 40–42, which still requires the removed Layout.preferredHeight; after correcting that, the checks at lines 155–158 and 186–188 still require the old inline controller.startScenarioSnapshot()) call. Running python3 apps/arstack_studio/tests/check_operator_workspace.py therefore exits immediately, and .github/workflows/arstack-studio-qt.yml runs this script in CI, so the commit cannot pass its Studio checks until all obsolete assertions are updated or removed.
Useful? React with 👍 / 👎.
8999bac
into
feature/studio-matched-ptp-sv-auto-20261017
1 participant
Preserve proven SV/PTP milestone
Base on the existing integrated M3C.6 PTP–SV candidate, no changes to embedded firmware, wire encoding, PTP, smpCnt, or AUTO qualification. The prior 120s capture with ~480k canonical SV, 0 counter gaps, local AUTO and consistent PTP epoch alignment remains the no-regression baseline. Keep Preview packaging servo ON, MAC evidence ON, mirror OFF, matched firmware commit.
Root cause: GUI phase mismatch
NumericField currently debounces accepted text for 90ms. If operator clicks START before that timer fires, the editor visibly shows −30° while the ListModel scenario contains old 0°; START serializes the model only. The new START path synchronously flushes both magnitude and angle editors on all eight channels and validates input before building the exclusive FIFO transaction. Invalid numeric text prevents START. No extra GUI-side duplicate signal cache, no per-packet work.
DeviceController::startWithScenarioalready serializes all 8 channels in one ordered FREQ/SET/ENABLE/SHAPE/START batch; preserve it unchanged.Operator UX
Validation
Qt GUI structural and build smoke, Windows Lifecycle and Native Preview, all exact-branch checks. Windows screenshot/physical comparison required for visual acceptance; baseline PTP–SV capture remains unchanged in this GUI-only change.