Skip to content

P0 Studio: preserve PTP–SV lock; improve 4I+4V fidelity and operator layouts - #244

Merged
masarray merged 17 commits into
feature/studio-matched-ptp-sv-auto-20261017from
fix/studio-value-fidelity-layout-p0-20261018
Oct 18, 2026
Merged

masarray merged 17 commits into
feature/studio-matched-ptp-sv-auto-20261017from
fix/studio-value-fidelity-layout-p0-20261018

Conversation

@masarray

Copy link
Copy Markdown
Owner

Non-regression boundary

No changes to PTP epoch servo, SV canonical packet schema, AUTO sample-phase criteria, MAC evidence, smpCnt or embedded firmware. User's verified 120s capture: 480294 canonical frames, 120 sequential smpCnt wraps, 120 PTP Sync/FUP/Announce, smpSynch=1, phase-alignment ~49us Windows RX proxy (not hardware sample phase).

Operator fixes

  • Enlarge SMV Injector brand icon/logo and label in ribbon across compact & regular.
  • Improve shared light-hover button readability and checkbox geometry across Advanced.
  • Use flexible vertical Voltage/Current matrices with no trailing empty spacer; preserve phasor/wave split and Start/Stop.
  • Strengthen structural tests: every START sends exact 8-channel current/voltage table snapshot with signed millidegree phase; no bare START path that leaves stale board data. The base branch already includes synchronous editor flush and an unconditional scenario START; keep those non-regression gates. Phasor/wave and PTP default startup already exist in base; do not introduce duplicate state machines.

Hold for evidence

User observed GUI Ia=-30° with PCAP Ia=0°. Source contains table snapshot transaction but capture is not proven to correspond to same active setpoints. Do not label GUI values as wire readback. Need live start transaction logs/PCAP matched in time; tests guard serialization and GUI-to-START path, not falsely claim hardware proof.

CI

Native Qt + Windows lifecycle and exact-commit Windows preview; protect PTP/SV lock baseline from any unrelated UX changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T05:19:47.258563Z 474e1d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit aa1a167 into feature/studio-matched-ptp-sv-auto-20261017 Oct 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant