Repository navigation
Conversation
Owner
Author
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Evaluation-only premium UX prototype for the ESP32-P4 SMV Injector GUI. This PR intentionally targets
feature/smv-injector-guirather thanmain; it remains Draft and must not be merged until the operator workflow and visual direction are approved.V3 — calm premium instrument pass
The latest review keeps the keyboard-first V2 workflow and focuses on visual quality and signal readability:
Typography
The UI now uses one preferred stack:
Inter -> Plus Jakarta Sans -> native system fallback; engineering numbers remain monospace for tabular alignment. The repository currently contains no local Inter/Plus Jakarta font binary, so this PR deliberately does not introduce a CDN/network dependency. Font vendoring can be handled separately once packaging/license policy is chosen.Fast workflow
Visualization truthfulness
Phasor and waveform are explicitly generated setpoint previews. They show what the injector is configured to generate and do not claim Ethernet on-wire proof. A later Observed path can be added without changing the cockpit structure.
Performance / validation
The GUI remains dependency-free HTML/CSS/JavaScript. Canvas rendering redraws only on state changes/resizes through
requestAnimationFrame. The ESP32-P4 remains the realtime SV authority. CI now syntax-checks bothapp.jsand the V3 preview renderer and verifies the V3 assets are present in the local-server smoke surface.Review focus
Please judge this PR on:
See
apps/smv_injector_gui/PREMIUM_UX_REVIEW.mdfor the detailed evaluation checklist.Scope / safety