Repository navigation
Fix Windows Qt launcher for Visual Studio 2026 - #68
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2f44ab2d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| $visualStudio = & $vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath | ||
| if ($VisualStudioRoot) { |
There was a problem hiding this comment.
Skip vswhere validation when an explicit root is supplied
When -VisualStudioRoot points to a valid installation but vswhere.exe is absent or unavailable, the launcher still throws at the unconditional validation on lines 15–18 before reaching this override branch. This defeats the new manual override precisely in environments where automatic discovery cannot be used; only require and invoke vswhere in the else branch.
Useful? React with 👍 / 👎.
Fix the ARStack Studio Windows launcher after a real VS2026 workstation failure.
Root cause:
Pathcould therefore be discarded, leaving CMake unable to locatecl.exe;Changes:
cl.exebefore CMake and pass the compiler explicitly;CMAKE_CXX_COMPILER-NOTFOUNDcache;-VisualStudioRootoverride;msvc2022_64folder is the Qt kit name, not a requirement to install the VS2022 IDE.