Skip to content

Add GitHub Actions workflow for Docker image build test - #13

Merged
maschnetwork merged 2 commits into
mainfrom
feature/docker-build-test-workflow
Mar 17, 2026
Merged

Add GitHub Actions workflow for Docker image build test#13
maschnetwork merged 2 commits into
mainfrom
feature/docker-build-test-workflow

Conversation

@kiro-agent

@kiro-agent kiro-agent Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

This pull request was generated by @kiro-agent 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro autonomous agent


Summary

Adds a GitHub Actions workflow that verifies the Docker image can be built successfully, addressing the lack of any CI validation for the Dockerfile.

Changes

  • Created .github/workflows/docker-build-test.yml with a workflow that:
    • Triggers on pull requests targeting main and on manual workflow_dispatch
    • Uses a build-test environment to gate execution behind maintainer approval
    • Checks out the repository and runs docker build (build only, no push)
    • Runs on ubuntu-latest

Setup required after merge

To enable the maintainer approval gate, you need to create the build-test environment in the repository settings:

  1. Go to Settings > Environments > New environment
  2. Name it build-test
  3. Check Required reviewers and add the maintainers who should approve builds
  4. Save the protection rules

Without this environment configuration, the workflow will run without requiring approval.

Adds a workflow that builds the Docker image to verify the Dockerfile
is valid. The workflow:
- Triggers on pull requests targeting main and manual dispatch
- Requires maintainer approval via the build-test environment
- Builds the image without pushing to validate correctness

Co-authored-by: Maximilian Schellhorn <36627945+maschnetwork@users.noreply.github.com>
@kiro-agent kiro-agent Bot mentioned this pull request Mar 17, 2026
@maschnetwork

Copy link
Copy Markdown
Owner

/kiro fix seems like the docker build failed but action shows successful - please verify

- Add --no-cache to ensure fresh builds without cached layers
- Add --progress=plain to show full build output in GitHub Actions logs
- Add verification step to confirm the Docker image was actually created
@kiro-agent

kiro-agent Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Here are the PRs I created:
#13

@maschnetwork
maschnetwork merged commit 4167258 into main Mar 17, 2026
1 check passed
@maschnetwork
maschnetwork deleted the feature/docker-build-test-workflow branch March 17, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants