Skip to content

solution#30

Open
Oleksiy-Lyashenko wants to merge 1 commit into
mate-academy:masterfrom
Oleksiy-Lyashenko:develop
Open

solution#30
Oleksiy-Lyashenko wants to merge 1 commit into
mate-academy:masterfrom
Oleksiy-Lyashenko:develop

Conversation

@Oleksiy-Lyashenko
Copy link
Copy Markdown

Copy link
Copy Markdown

@vkryvytskyi vkryvytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Шрифт в футере очень маленький
image
А тут блок наехал на картинку

Comment thread src/index.html
Comment on lines +130 to +142
<img src="./images/logo-1.svg" alt="">

<img src="./images/logo-2.svg" alt="">

<img src="./images/logo-3.svg" alt="">

<img src="./images/logo-4.svg" alt="">

<img src="./images/logo-5.svg" alt="">

<img src="./images/logo-6.svg" alt="">

<img src="./images/logo-7.svg" alt="">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не оставляй alt пустым

Comment thread src/index.html
Comment on lines +151 to +154
<img
src="./images/Graphic-main.png"
alt=""
class="main__photo">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img
src="./images/Graphic-main.png"
alt=""
class="main__photo">
<img
src="./images/Graphic-main.png"
alt=""
class="main__photo"
>

Comment thread src/index.html
Comment on lines +198 to +201
<img
src="./images/Icon__main-3.svg"
alt=""
class="main__text-photo">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img
src="./images/Icon__main-3.svg"
alt=""
class="main__text-photo">
<img
src="./images/Icon__main-3.svg"
alt=""
class="main__text-photo"
>

Поправь форматирование

Comment thread src/index.html
<div class="testimonials__photo-container">
<img
src="./images/testimonials-3.svg"
alt=""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пустой alt

Comment thread src/index.html

<ul class="footer__subtitle">
<li class="footer__item">
<a href="" class="footer__link">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не оставляй href пустым, указывай решетку как плейсхолдер

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants