Skip to content

solution#561

Open
KateBerd wants to merge 11 commits into
mate-academy:masterfrom
KateBerd:develop
Open

solution#561
KateBerd wants to merge 11 commits into
mate-academy:masterfrom
KateBerd:develop

Conversation

@KateBerd
Copy link
Copy Markdown

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost finished!

  1. Please reset all CSS Autofill styles in your form:
Image
  1. Would you mind to add some hover effects on pictures? scale(1.04) with smooth effect will be perfect choice

@KateBerd KateBerd requested a review from Anton-Kuchmasov May 20, 2026 08:07
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, but you still need to add some improvements

  1. there should not be a white line
Image
  1. these should be address, tel and mailto link
Image
  1. fix the positioning of your books in the footer
    your:
Image

example:

Image

@KateBerd KateBerd requested a review from etojeDenys May 20, 2026 10:40
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. Looks broken on mobile screen:
Image
  1. Add hover to all interactive elements: images, buttons, links etc.

  2. Add the favicon to browser tab.

  3. Page should not jump to top after form submit.

@KateBerd KateBerd requested a review from brespect May 20, 2026 13:17
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job
also, this link should open in a new tab
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants