feat: completed task thrive_talk#56
Open
VolodymyrKlepykov wants to merge 8 commits into
Open
Conversation
danylo-onishchuk
suggested changes
Jun 8, 2021
danylo-onishchuk
left a comment
There was a problem hiding this comment.
Сделай часы работы в одну строчку
Сделай кликабельным номер телефона и имейл
Добавь на разноцветные блоки анимашку, что было повеселее
Навигация не работает
для мобилки лучше сделать бургер меню
danylo-onishchuk
suggested changes
Jun 9, 2021
danylo-onishchuk
left a comment
There was a problem hiding this comment.
для телефона лучше что то типо этого
https://snipp.ru/html-css/site-phone
было бы круто, чтоб по клику на адрес открывались гугл карты с этим адресом. есть готовое решение, почитай про него.
бургер меню лучше сделать на весь экран и с беграундом
тут поехало
придерживайся одних размеров на всей странице
danylo-onishchuk
suggested changes
Jun 9, 2021
Author
danylo-onishchuk
suggested changes
Jun 10, 2021
danylo-onishchuk
left a comment
There was a problem hiding this comment.
адрес отлично, бургер отлично
фон хидера ты не растянул
danylo-onishchuk
suggested changes
Jun 10, 2021
| } | ||
|
|
||
| &__link { | ||
| // margin-top: 63px; |
| @import "./blocks/info.scss"; | ||
| @import "./blocks/header.scss"; | ||
|
|
||
| @font-face { |
danylo-onishchuk
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



DEMO LINK