Skip to content

solution#62

Open
Oleksiy-Lyashenko wants to merge 3 commits into
mate-academy:masterfrom
Oleksiy-Lyashenko:develop
Open

solution#62
Oleksiy-Lyashenko wants to merge 3 commits into
mate-academy:masterfrom
Oleksiy-Lyashenko:develop

Conversation

@Oleksiy-Lyashenko
Copy link
Copy Markdown

Прошу прощения, за то что скопировал названия пулл :)
Сделал это на автомате

Copy link
Copy Markdown

@vkryvytskyi vkryvytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Где ссылка на gh-pages, чтобы можно было проклацать лендинг?

Comment thread src/index.html Outdated
<div class="container">
<div class="header__container">
<div class="header__nav">
<div class="nav">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему это не элемент nav?

Comment thread src/index.html
Comment on lines +62 to +66
<h1 class="header__title">
HELPING YOU THRIVE
<br>
IN ALL AREAS OF LIFE
</h1>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут текст пиши обычным текстом, а через css делай uppercase

Comment thread src/index.html Outdated
Comment on lines +168 to +170
<h1 class="about__block-title">
Weight Lifting
</h1>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обычно на страницу добавляют 1-2 тегов h1

@Oleksiy-Lyashenko
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@mykola-yarchuk mykola-yarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
ці лінки нікуди не ведуть

image
на цій кнопці немає курсор поінтер, додай курсор поінтер всюди на що можна клікнтути
image
нижня частина кнопки бургер меню закривається цим блоком і клінкути стає дуже важко

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants