-
Notifications
You must be signed in to change notification settings - Fork 1.7k
task solution #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damian-k-dev
wants to merge
4
commits into
mate-academy:master
Choose a base branch
from
damian-k-dev:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
task solution #1773
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,24 @@ | ||
| 1. Replace `<your_account>` with your Github username in the link | ||
| - [DEMO LINK](https://<your_account>.github.io/js_gallery_DOM/) | ||
| - [DEMO LINK](https://damian-dev.github.io/js_gallery_DOM/) | ||
| 2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/) | ||
| - Run `npm run test` command to test your code; | ||
| - Run `npm run test:only -- -n` to run fast test ignoring linter; | ||
| - Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter. | ||
| - Run `npm run test` command to test your code; | ||
| - Run `npm run test:only -- -n` to run fast test ignoring linter; | ||
| - Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter. | ||
|
|
||
| ### Task: Create a gallery | ||
|
|
||
| Create an image gallery where the main image changes by the click on a thumbnail. | ||
|
|
||
| **Requirements:** | ||
|
|
||
| - A click can be either on a small `img` image or on `a` outside of it. `event.target` | ||
| will be, respectively, either `img` or `a`. | ||
| will be, respectively, either `img` or `a`. | ||
|
|
||
| **Notes:** | ||
|
|
||
| - Use event delegation. | ||
| - You must only modify the file `src/scripts/main.js`. | ||
|
|
||
| ### Gif of result | ||
|
|
||
|  |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,20 @@ | ||
| 'use strict'; | ||
|
|
||
| const gallery = document.querySelector('.gallery'); | ||
| const largeImg = document.querySelector('#largeImg'); | ||
|
|
||
| gallery.addEventListener('click', (e) => { | ||
| e.preventDefault(); | ||
|
|
||
| const linkElement = e.target.closest('a'); | ||
|
|
||
| if (!linkElement) { | ||
| return; | ||
| } | ||
|
|
||
| const linkElHRef = e.target.closest('a').href; | ||
|
|
||
| linkElement.setAttribute('data-link', linkElHRef); | ||
|
|
||
| largeImg.src = linkElement.getAttribute('data-link'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reading from |
||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The null check is in the wrong position. Lines 10 and 12 access
linkElementproperties before the check on line 14, which will throw an error when clicking outside an anchor element.