solution#1814
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The code contains syntax errors that prevent execution. On lines 16-17 in src/scripts/main.js, the CSS style values for top and right are missing the concatenation operator. Change posTop 'px' to posTop + 'px' and posRight 'px' to posRight + 'px'. These missing + operators cause a JavaScript parsing error, which blocks the linter and prevents the test suite from running. Once the concatenation operators are added, the notification function should work correctly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| div.appendChild(h2); | ||
| div.appendChild(p); | ||
| div.style.position = 'absolute'; | ||
| div.style.top = posTop 'px'; |
There was a problem hiding this comment.
Missing concatenation operator. The style value should be posTop + 'px' instead of posTop 'px'. This syntax error will prevent the top position from being set correctly.
| div.appendChild(p); | ||
| div.style.position = 'absolute'; | ||
| div.style.top = posTop 'px'; | ||
| div.style.right = posRight 'px'; |
There was a problem hiding this comment.
Missing concatenation operator. The style value should be posRight + 'px' instead of posRight 'px'. This syntax error will prevent the right position from being set correctly.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
you need to pass all tests
also please add DEMO LINK to PR's description
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Try to pass all tests
If you have any questions - feel free to ask in chat
4 participants
No description provided.