Solution#1090
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your test file does not meet the task requirements. Out of 4 required test cases, only 1 is correctly implemented. The test case for splitInteger(8, 1) === [8] is missing - you used splitInteger(6, 1) instead, which doesn't match the specification. Additionally, the test cases for splitInteger(17, 4) and splitInteger(32, 6) are completely missing. The task specifies exact input/output pairs that must be tested, and your file doesn't include them. Please update your test file to include all 4 required test cases with the exact values specified in the requirements: (8,1), (6,2), (17,4), and (32,6).
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| when splitting into 1 part`, () => { | ||
| expect(splitInteger(6, 1)).toEqual([6]); |
There was a problem hiding this comment.
The task requirements specify testing splitInteger(8, 1) === [8], but this test uses splitInteger(6, 1) === [6]. Please use the exact value 8 as specified.
| test('should sort parts ascending if they are not equal', () => { | ||
| expect(splitInteger(13, 3)).toEqual([4, 4, 5]); |
There was a problem hiding this comment.
This test case is not in the requirements. The task specifies these exact cases: (8,1), (6,2), (17,4), (32,6). This test can be removed.
| test('should add zeros if value < numberOfParts', () => { | ||
| expect(splitInteger(3, 4)).toEqual([0, 1, 1, 1]); |
There was a problem hiding this comment.
This test case is not in the requirements. The task specifies these exact cases: (8,1), (6,2), (17,4), (32,6). This test can be removed.
| test('should add zeros if value < numberOfParts', () => { | ||
| expect(splitInteger(3, 4)).toEqual([0, 1, 1, 1]); |
There was a problem hiding this comment.
Required test case splitInteger(17, 4) === [4, 4, 4, 5] is missing.
| test('should add zeros if value < numberOfParts', () => { | ||
| expect(splitInteger(3, 4)).toEqual([0, 1, 1, 1]); |
There was a problem hiding this comment.
Required test case splitInteger(32, 6) === [5, 5, 5, 5, 6, 6] is missing.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The request meets the required criteria.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.