Create tests22#930
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your work! There is a critical issue: the implementation sorts the result before returning, but the expected output arrays in the tests have the larger numbers at the end, not the beginning. If the order of the output matters (as implied by the tests), sorting the result will produce incorrect outputs. Please update your implementation to return the result in the correct order—typically, the larger parts (those with the extra 1) should come first or last as required by the task or tests, and you should remove the sorting step if it is not required. Once this is fixed, your solution should meet all requirements! 👍
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| result[i]++; | ||
| } | ||
|
|
||
| return result.sort((a, b) => a - b); |
There was a problem hiding this comment.
Sorting the result here may violate the requirement if the task expects the larger parts (those with the extra 1) to come first. Please check the task description or checklist regarding the required order of the output. If order matters, remove the .sort((a, b) => a - b) and return result as is.
| expect(splitInteger(17, 4)).toEqual([4, 4, 4, 5]); | ||
| expect(splitInteger(32, 6)).toEqual([5, 5, 5, 5, 6, 6]); |
There was a problem hiding this comment.
The expected output arrays have the larger numbers at the end, which may not match the output of the current implementation if it sorts the result. Please ensure that the implementation of splitInteger returns the parts in the correct order as expected by these tests.
Oleksii-Siviolov
left a comment
Oleksii-Siviolov
left a comment
There was a problem hiding this comment.
You have the example of the tests in the file, which was in the task (we even cloned it on the Q&A session). Please do not remove anything from the existing file and just add your expects. Also, do not add anything extra (which you do not understand).
3 participants
No description provided.