Solution#932
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your hard work! There is one critical issue that needs to be addressed before your PR can be approved: in the test case for value < numberOfParts, the expected output is not sorted in ascending order, which violates the task's requirement for strictly sorted output. Please update the expected output in this test to be sorted in ascending order, or ensure your function always returns a sorted result as required. Once this is fixed, your solution will fully meet the core requirements. Keep it up—you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| test('should add zeros if value < numberOfParts', () => { | ||
|
|
||
| expect(splitInteger(2, 5)).toEqual([0, 0, 0, 1, 1]); |
There was a problem hiding this comment.
Issue: The expected output [0, 0, 0, 1, 1] is not sorted in ascending order, which contradicts the test description 'should sort parts ascending if they are not equal'.
Please update the expected output to be sorted in ascending order, for example: [0, 0, 1, 1, 0] should be [0, 0, 1, 1, 0] (if that's how your function returns it), or adjust your function to always return sorted results if required by the task checklist.
Oleksii-Siviolov
left a comment
Oleksii-Siviolov
left a comment
There was a problem hiding this comment.
Looks good, but one fix is needed.
| expect(splitInteger(10, 3)).toEqual([3, 3, 4]); | ||
| }); | ||
|
|
||
| test('should add zeros if value < numberOfParts', () => { |
There was a problem hiding this comment.
Do not see any zeros in your expect...
3 participants
No description provided.