-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: camelCase variables #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: camelCase variables #1804
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -358,3 +358,36 @@ const people = [ | |
| console.log(people); // you can remove it | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a leftover debug statement |
||
|
|
||
| // write your code here | ||
| const table = document.querySelector('.dashboard'); | ||
|
|
||
| people.forEach((person) => { | ||
| const row = document.createElement('tr'); | ||
|
|
||
| const nameCell = document.createElement('td'); | ||
|
|
||
| nameCell.textContent = person.name; | ||
|
|
||
| const genderCell = document.createElement('td'); | ||
|
|
||
| genderCell.textContent = person.sex === 'm' ? 'Male' : 'Female'; | ||
|
Comment on lines
+370
to
+372
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure you are not shadowing or redefining |
||
|
|
||
| const bornCell = document.createElement('td'); | ||
|
|
||
| bornCell.textContent = person.born; | ||
|
|
||
| const diedCell = document.createElement('td'); | ||
|
|
||
| diedCell.textContent = person.died; | ||
|
|
||
| const ageCell = document.createElement('td'); | ||
|
|
||
| ageCell.textContent = person.died - person.born; | ||
|
|
||
| const centuryCell = document.createElement('td'); | ||
|
|
||
| centuryCell.textContent = Math.ceil(person.died / 100); | ||
|
|
||
| row.append(nameCell, genderCell, bornCell, diedCell, ageCell, centuryCell); | ||
|
|
||
| table.appendChild(row); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this debugging
console.log(people)per checklist (medium): it should not remain in the final submission.