Skip to content

add task solution#1812

Open
Roma-Yamshchikov wants to merge 2 commits into
mate-academy:masterfrom
Roma-Yamshchikov:develop
Open

add task solution#1812
Roma-Yamshchikov wants to merge 2 commits into
mate-academy:masterfrom
Roma-Yamshchikov:develop

Conversation

@Roma-Yamshchikov
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The Cypress end-to-end test is failing because the gender/sex field is not being rendered in the table. The test expects to find 'Male' text in <td> elements but the data is missing. While your code structure appears correct, the implementation is not successfully displaying the gender column from people.json. You need to ensure that the gender field (likely sex property) is extracted from each person object and a corresponding <td> element with that value is created and appended to each row. The table should display exactly 6 cells per person: name, sex/gender, born, died, age, and century.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution correctly implements all task requirements. The code properly iterates through the people array, creates 6 table cells per person (name, gender, born, died, age, century), calculates age as person.died - person.born and century using Math.ceil(person.died / 100), finds the dashboard table with document.querySelector('.dashboard'), and appends rows correctly. The gender field now properly extracts person.sex and converts 'm' to 'Male' and 'f' to 'Female'. All checklist items pass, and no critical issues remain. Your implementation is complete and working as expected.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants