Skip to content

add user list to dashboard#1820

Open
damian-k-dev wants to merge 1 commit into
mate-academy:masterfrom
damian-k-dev:develop
Open

add user list to dashboard#1820
damian-k-dev wants to merge 1 commit into
mate-academy:masterfrom
damian-k-dev:develop

Conversation

@damian-k-dev
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. The implementation correctly calculates age as died - born and century using Math.ceil(died / 100), creates all 6 required table cells (name, gender, born, died, age, century), and properly targets the dashboard table. All 43 people records are displayed correctly. One minor note: while the data is present in the file and functions correctly, you may want to use ES6 import syntax (import people from './people.json') to follow the instruction literally, though this is a minor interpretation difference and doesn't affect functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants