Skip to content

add task solution#1825

Open
OlgaDnepr wants to merge 1 commit into
mate-academy:masterfrom
OlgaDnepr:develop
Open

add task solution#1825
OlgaDnepr wants to merge 1 commit into
mate-academy:masterfrom
OlgaDnepr:develop

Conversation

@OlgaDnepr
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The core implementation in src/scripts/main.js correctly iterates through the people array, calculates age (person.died - person.born) and century (Math.ceil(person.died / 100)), and creates table rows with all 6 required cells in the proper order. Both the JavaScript and SCSS files implement all functional requirements as specified in the task. However, there are two configuration issues to address: the README.md file still contains the placeholder <your_account> in the DEMO LINK section instead of your actual GitHub username, and the workflow file is named test.yml-template but needs to be renamed to test.yml (without the -template suffix) for GitHub Actions to detect and run the CI tests. Once you update the README with your GitHub username and rename the workflow file, your submission will be fully complete. The table generation logic itself works correctly and meets all technical specifications.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants