-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add task solution #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add task solution #1994
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,44 @@ | ||
| 'use strict'; | ||
|
|
||
| // write code here | ||
| function parseSalaryToNumber(salaryString) { | ||
| const cleanString = salaryString.replace(/[$,]/g, ''); | ||
|
|
||
| return Number(cleanString); | ||
| } | ||
|
|
||
| function getEmployees() { | ||
| const listChildren = document.querySelectorAll('ul li'); | ||
| const arrayListChildren = [...listChildren]; | ||
|
|
||
| return arrayListChildren.map((li) => { | ||
| return { | ||
| element: li, | ||
| name: li.textContent.trim(), | ||
| position: li.dataset.position, | ||
| salary: li.dataset.salary, | ||
| age: Number(li.dataset.age), | ||
| }; | ||
|
Comment on lines
+14
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CHECKLIST ITEM #8 VIOLATION: The employee object schema must be exactly |
||
| }); | ||
| } | ||
|
|
||
|
|
||
| function sortList(list) { | ||
| const employees = getEmployees(); | ||
|
|
||
| employees.sort((a, b) => { | ||
| const salaryA = parseSalaryToNumber(a.salary); | ||
| const salaryB = parseSalaryToNumber(b.salary); | ||
|
|
||
| return salaryB - salaryA; | ||
| }); | ||
|
|
||
| list.innerHTML = ''; | ||
|
|
||
| employees.forEach((employee) => { | ||
| list.appendChild(employee.element); | ||
| }); | ||
| } | ||
|
|
||
| const listElement = document.querySelector('ul'); | ||
|
|
||
| sortList(listElement); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CHECKLIST ITEM #9 VIOLATION: Both functions must be explicitly called. Currently only |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHECKLIST ITEM #7 VIOLATION: The
getEmployeesfunction must take alistparameter as required by the task. Currently it queriesul lidirectly instead of using the parameter. Update the function signature tofunction getEmployees(list)and uselist.querySelectorAll('li')instead.