Skip to content

Develop#6223

Open
vladyslav-kukhar wants to merge 1 commit into
mate-academy:masterfrom
vladyslav-kukhar:develop
Open

Develop#6223
vladyslav-kukhar wants to merge 1 commit into
mate-academy:masterfrom
vladyslav-kukhar:develop

Conversation

@vladyslav-kukhar
Copy link
Copy Markdown

  • DEMO LINK

  • TEST REPORT LINK

  • All components follow BEM and use SCSS

  • Repeated sizes and special colors are put to variables

  • Grid is used for the columns

  • Cards are shown in 1, 2, 3, or 4 columns based on screen resolution

  • All changes on :hover are smooth

  • Code follows all the Code Style Rules ❗️

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all functional requirements from the task. The grid layout handles responsive breakpoints correctly (1/2/3/4 columns), all data-qa attributes are in place, hover transitions use 300ms duration as specified, SCSS variables are properly defined, and the is-active class is correctly applied to the first nav link. The only noted issue is a BEM methodology concern where .is-active is defined as a standalone class rather than namespaced within the Nav block (e.g., .nav__link--active). While following BEM conventions is good practice, this is a code style preference rather than a functional blocker—your code works correctly and all tests pass. The .is-active class functions as intended and doesn't break any functionality. The implementation demonstrates solid understanding of CSS Grid, responsive design, and SCSS architecture. Great work on meeting all the core requirements!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/index.html
<li class="nav__item">
<a
href="#"
class="nav__link"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .is-active class is defined as a standalone class outside any BEM block in header.scss. According to BEM methodology, it should be scoped within the Nav block, e.g., .nav__link--active or .nav__link.is-active. This makes the code structure clearer and maintains proper BEM hierarchy.

&__rate {
margin-top: 16px;
display: flex;
justify-content: space-between;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to BEM methodology, the is-active class should follow the block naming convention. Consider using .nav__link--active or nesting the modifier within the .nav block (e.g., .nav__link.is-active). This ensures proper BEM structure where modifiers are part of their associated block/element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants