Develop#6223
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all functional requirements from the task. The grid layout handles responsive breakpoints correctly (1/2/3/4 columns), all data-qa attributes are in place, hover transitions use 300ms duration as specified, SCSS variables are properly defined, and the is-active class is correctly applied to the first nav link. The only noted issue is a BEM methodology concern where .is-active is defined as a standalone class rather than namespaced within the Nav block (e.g., .nav__link--active). While following BEM conventions is good practice, this is a code style preference rather than a functional blocker—your code works correctly and all tests pass. The .is-active class functions as intended and doesn't break any functionality. The implementation demonstrates solid understanding of CSS Grid, responsive design, and SCSS architecture. Great work on meeting all the core requirements!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" |
There was a problem hiding this comment.
The .is-active class is defined as a standalone class outside any BEM block in header.scss. According to BEM methodology, it should be scoped within the Nav block, e.g., .nav__link--active or .nav__link.is-active. This makes the code structure clearer and maintains proper BEM hierarchy.
| &__rate { | ||
| margin-top: 16px; | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
According to BEM methodology, the is-active class should follow the block naming convention. Consider using .nav__link--active or nesting the modifier within the .nav block (e.g., .nav__link.is-active). This ensures proper BEM structure where modifiers are part of their associated block/element.
DEMO LINK
TEST REPORT LINK
All components follow BEM and use SCSS
Repeated sizes and special colors are put to variables
Grid is used for the columns
Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
All changes on :hover are smooth
Code follows all the Code Style Rules ❗️