Develop#6226
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is well-structured with proper BEM naming, SCSS variables, responsive grid layout, and header hover effects. However, two critical hover effects are missing from card.scss that are explicitly required by the task: 1. Card scale on hover: Add transform: scale(1.2) with transition: transform 0.3s to .card to make it 20% larger when hovered. Use transform-origin: center or transform-origin: top center to ensure the card scales from its center. 2. Card title color change: Add .card:hover .card__title { color: #34568b; } to change the title color when the card is hovered. Add a transition: color 0.3s to the title element for smooth animation. These requirements are clearly specified in the task description and correspond to [CHECKLIST ITEM #1]. Once these hover effects are implemented, your solution will be complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| .header { | ||
| padding: 0 50px; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1 and the task requirements: The card should scale by 20% (1.2 times) on hover. Add transform: scale(1.2) and &:hover with the transform property to achieve the required effect.
| display: block; | ||
| } | ||
|
|
||
| &__menu-list { | ||
| display: flex; | ||
| font-weight: 500; |
There was a problem hiding this comment.
This violates checklist item #1 and the task requirements: The card title text color should change to #34568b when the card is hovered using .card:hover .card__title. This hover effect on the title element is currently missing.
|
|
||
| &__name { | ||
| margin: 40px 0 4px; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| line-height: 18px; |
There was a problem hiding this comment.
Missing hover effect for card title. The task requires changing the title text color to #34568b when the card is hovered using .card:hover .card__title. Add a color property to &__name with a transition, and add a .card:hover .card__title rule to change the color.
|
|
||
| .card { | ||
| box-sizing: border-box; | ||
| width: 200px; | ||
| padding: 32px 16px 16px; | ||
| border-radius: 5px; | ||
| border: 1px solid #f3f3f3; | ||
|
|
||
| &__image { | ||
| display: block; | ||
| width: 160px; | ||
| height: 134px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| &__name { | ||
| margin: 40px 0 4px; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| line-height: 18px; | ||
| } | ||
|
|
||
| &__code { | ||
| display: block; | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| color: $secondary-text-color; | ||
| } | ||
|
|
||
| &__rate { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| margin: 16px 0 24px; | ||
| } | ||
|
|
||
| &__reviews { | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| } | ||
|
|
||
| &__price-info { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| &__price { | ||
| font-size: 12px; | ||
| line-height: 18px; | ||
| color: $secondary-text-color; | ||
| } | ||
|
|
||
| &__price-value { | ||
| font-size: 16px; | ||
| font-weight: 700; | ||
| line-height: 18px; | ||
| } | ||
|
|
||
| &__buy { | ||
| display: block; | ||
| box-sizing: border-box; | ||
| width: 100%; | ||
| height: 40px; | ||
| text-decoration: none; | ||
| text-align: center; | ||
| background: $blue-color; | ||
| color: #fff; | ||
| font-weight: 700; | ||
| font-size: 14px; | ||
| line-height: 40px; | ||
| text-transform: uppercase; | ||
| margin-top: 16px; | ||
| border-radius: 5px; | ||
| border: 1px solid $blue-color; | ||
| transition: | ||
| background-color 0.3s, | ||
| color 0.3s; | ||
|
|
||
| &:hover { | ||
| background: #fff; | ||
| color: $blue-color; | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing 20% scale transform on card hover. The task requires increasing the card by 20 percent on hover with smooth 300ms transition. Add transform: scale(1.2) and transition: transform 0.3s to the .card block. Neighboring cards should not be affected, so ensure proper transform-origin is set.
| } | ||
| } | ||
|
|
||
| @for $i from 1 through 5 { | ||
| &--#{$i} { | ||
| .stars__star:nth-child(-n + #{$i}) { |
There was a problem hiding this comment.
This violates checklist item #1. The task explicitly requires using .card:hover .card__title selector to change the title text color to #34568b when the card is hovered. Add a transition for the color property and the hover rule targeting the title element.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all core requirements. The code demonstrates proper BEM methodology, correct SCSS structure with variables, responsive grid layout with the specified breakpoints (488px, 768px, 1024px), and all required hover effects with data-qa attributes in place. The card hover (scale 1.2, title color change to #34568b) and nav hover effects (#00acdc) are correctly implemented. The transition duration of 1s instead of 0.3s is a minor deviation from the spec but doesn't prevent the task from functioning — all hover effects remain smooth and the visual experience is intact. There are also commented-out code blocks in header.scss that can be cleaned up for better code hygiene, but these don't affect functionality.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| rel="stylesheet" | ||
| /> | ||
| <link | ||
| rel="preconnect" |
There was a problem hiding this comment.
The card title transition duration is 1s but the task requires all hover changes to be smooth during 300ms. Change transition: color 1s; to transition: color 0.3s;
| @media (min-width: 768px) { | ||
| grid-template-columns: repeat(3, 200px); | ||
| } | ||
|
|
There was a problem hiding this comment.
The title transition duration is 1s but should be 0.3s to match the requirement for all hover effects to be smooth (300ms duration).
| height: 40px; | ||
| } | ||
|
|
||
| &__logo-link { |
There was a problem hiding this comment.
The card title has a transition duration of 1s, but the task explicitly requires all hover changes to be smooth during 300ms. Change this to transition: color 0.3s; to match the requirement.
| @use './variables.scss' as *; | ||
|
|
||
| .card { | ||
| box-sizing: border-box; | ||
| width: 200px; | ||
| padding: 32px 16px 16px; | ||
| border-radius: 5px; | ||
| border: 1px solid #f3f3f3; | ||
| transition: transform 0.3s; | ||
|
|
||
| &__title { | ||
| margin: 40px 0 4px; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| line-height: 18px; | ||
| transition: color 1s; | ||
| } | ||
|
|
||
| &:hover { | ||
| transform: scale(1.2); | ||
| transform-origin: center; | ||
|
|
||
| .card__title { | ||
| color: #34568b; | ||
| } | ||
| } | ||
|
|
||
| &__image { | ||
| display: block; | ||
| width: 160px; |
There was a problem hiding this comment.
This file uses $main-text-color but doesn't import the variables file. Add @use './variables' as *; at the top of the file.
| &__title { | ||
| margin: 40px 0 4px; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| line-height: 18px; |
There was a problem hiding this comment.
The card title transition duration is 1s, but the task requires all hover effects to be smooth with 300ms duration. Change to transition: color 0.3s;
| background-image: url('../images/star.svg'); | ||
|
|
||
| &:last-child { | ||
| margin-right: 0; |
There was a problem hiding this comment.
The title transition duration is 1s but should be 0.3s to match the requirement for all hover effects to be smooth (300ms).
https://azesmmisha.github.io/layout_catalog/
https://azesmmisha.github.io/layout_catalog/report/html_report/
:hoverare smooth