Skip to content

Develop#6226

Open
azesmmisha wants to merge 5 commits into
mate-academy:masterfrom
azesmmisha:develop
Open

Develop#6226
azesmmisha wants to merge 5 commits into
mate-academy:masterfrom
azesmmisha:develop

Conversation

@azesmmisha
Copy link
Copy Markdown

https://azesmmisha.github.io/layout_catalog/
https://azesmmisha.github.io/layout_catalog/report/html_report/

  • [ x ] All components follow BEM and use SCSS
  • [ x ] Repeated sizes and special colors are put to variables
  • [ x ] Grid is used for the columns
  • [ x ] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
  • [ x ] All changes on :hover are smooth
  • [ x ] Code follows all the [Code Style Rules ❗️]

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is well-structured with proper BEM naming, SCSS variables, responsive grid layout, and header hover effects. However, two critical hover effects are missing from card.scss that are explicitly required by the task: 1. Card scale on hover: Add transform: scale(1.2) with transition: transform 0.3s to .card to make it 20% larger when hovered. Use transform-origin: center or transform-origin: top center to ensure the card scales from its center. 2. Card title color change: Add .card:hover .card__title { color: #34568b; } to change the title color when the card is hovered. Add a transition: color 0.3s to the title element for smooth animation. These requirements are clearly specified in the task description and correspond to [CHECKLIST ITEM #1]. Once these hover effects are implemented, your solution will be complete.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/styles/header.scss
Comment on lines +3 to +8
.header {
padding: 0 50px;
display: flex;
align-items: center;
justify-content: space-between;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1 and the task requirements: The card should scale by 20% (1.2 times) on hover. Add transform: scale(1.2) and &:hover with the transform property to achieve the required effect.

Comment thread src/styles/header.scss
Comment on lines +16 to +21
display: block;
}

&__menu-list {
display: flex;
font-weight: 500;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1 and the task requirements: The card title text color should change to #34568b when the card is hovered using .card:hover .card__title. This hover effect on the title element is currently missing.

Comment thread src/styles/card.scss Outdated
Comment on lines +16 to +21

&__name {
margin: 40px 0 4px;
font-size: 12px;
font-weight: 500;
line-height: 18px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing hover effect for card title. The task requires changing the title text color to #34568b when the card is hovered using .card:hover .card__title. Add a color property to &__name with a transition, and add a .card:hover .card__title rule to change the color.

Comment thread src/styles/card.scss
Comment on lines +2 to +85

.card {
box-sizing: border-box;
width: 200px;
padding: 32px 16px 16px;
border-radius: 5px;
border: 1px solid #f3f3f3;

&__image {
display: block;
width: 160px;
height: 134px;
margin: 0 auto;
}

&__name {
margin: 40px 0 4px;
font-size: 12px;
font-weight: 500;
line-height: 18px;
}

&__code {
display: block;
font-size: 10px;
line-height: 14px;
color: $secondary-text-color;
}

&__rate {
display: flex;
align-items: center;
justify-content: space-between;
margin: 16px 0 24px;
}

&__reviews {
font-size: 10px;
line-height: 14px;
}

&__price-info {
display: flex;
align-items: center;
justify-content: space-between;
}

&__price {
font-size: 12px;
line-height: 18px;
color: $secondary-text-color;
}

&__price-value {
font-size: 16px;
font-weight: 700;
line-height: 18px;
}

&__buy {
display: block;
box-sizing: border-box;
width: 100%;
height: 40px;
text-decoration: none;
text-align: center;
background: $blue-color;
color: #fff;
font-weight: 700;
font-size: 14px;
line-height: 40px;
text-transform: uppercase;
margin-top: 16px;
border-radius: 5px;
border: 1px solid $blue-color;
transition:
background-color 0.3s,
color 0.3s;

&:hover {
background: #fff;
color: $blue-color;
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 20% scale transform on card hover. The task requires increasing the card by 20 percent on hover with smooth 300ms transition. Add transform: scale(1.2) and transition: transform 0.3s to the .card block. Neighboring cards should not be affected, so ensure proper transform-origin is set.

Comment thread src/styles/stars.scss
Comment on lines +16 to +21
}
}

@for $i from 1 through 5 {
&--#{$i} {
.stars__star:nth-child(-n + #{$i}) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1. The task explicitly requires using .card:hover .card__title selector to change the title text color to #34568b when the card is hovered. Add a transition for the color property and the hover rule targeting the title element.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all core requirements. The code demonstrates proper BEM methodology, correct SCSS structure with variables, responsive grid layout with the specified breakpoints (488px, 768px, 1024px), and all required hover effects with data-qa attributes in place. The card hover (scale 1.2, title color change to #34568b) and nav hover effects (#00acdc) are correctly implemented. The transition duration of 1s instead of 0.3s is a minor deviation from the spec but doesn't prevent the task from functioning — all hover effects remain smooth and the visual experience is intact. There are also commented-out code blocks in header.scss that can be cleaned up for better code hygiene, but these don't affect functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/index.html
rel="stylesheet"
/>
<link
rel="preconnect"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card title transition duration is 1s but the task requires all hover changes to be smooth during 300ms. Change transition: color 1s; to transition: color 0.3s;

Comment thread src/styles/catalog.scss
@media (min-width: 768px) {
grid-template-columns: repeat(3, 200px);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title transition duration is 1s but should be 0.3s to match the requirement for all hover effects to be smooth (300ms duration).

Comment thread src/styles/header.scss
height: 40px;
}

&__logo-link {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card title has a transition duration of 1s, but the task explicitly requires all hover changes to be smooth during 300ms. Change this to transition: color 0.3s; to match the requirement.

Comment thread src/styles/card.scss
Comment on lines +1 to +30
@use './variables.scss' as *;

.card {
box-sizing: border-box;
width: 200px;
padding: 32px 16px 16px;
border-radius: 5px;
border: 1px solid #f3f3f3;
transition: transform 0.3s;

&__title {
margin: 40px 0 4px;
font-size: 12px;
font-weight: 500;
line-height: 18px;
transition: color 1s;
}

&:hover {
transform: scale(1.2);
transform-origin: center;

.card__title {
color: #34568b;
}
}

&__image {
display: block;
width: 160px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file uses $main-text-color but doesn't import the variables file. Add @use './variables' as *; at the top of the file.

Comment thread src/styles/card.scss
Comment on lines +11 to +15
&__title {
margin: 40px 0 4px;
font-size: 12px;
font-weight: 500;
line-height: 18px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card title transition duration is 1s, but the task requires all hover effects to be smooth with 300ms duration. Change to transition: color 0.3s;

Comment thread src/styles/stars.scss
background-image: url('../images/star.svg');

&:last-child {
margin-right: 0;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title transition duration is 1s but should be 0.3s to match the requirement for all hover effects to be smooth (300ms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants